set podInformer/serviceInformer in NewJobController

[sperlingxx]

Binding podInformer and serviceInformer onto jobController when we initialize a jobController by calling NewJobController.

---

This change is 

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: terrytangyuan

If they are not already assigned, you can assign the PR to them by writing /assign @terrytangyuan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sperlingxx]

/assign @terrytangyuan

[terrytangyuan]

/lgtm

[gaocegege]

/lgtm
/cc @johnugeorge @richardsliu

[jian-he]

After #36 the usage of podLister/serviceLister are removed, do we still need this change ?
If projects use kube-builder to generate the skeleton code, then I think the raw podInformer/serviceInformer structure won't be needed too.

[gaocegege]

We do not use kubebuilder now. Thus we need the informer to watch resources in apiserver. But I am not sure if listers are needed here.

[gaocegege]

Did we decided to use kubebuilder in tf-operator and pytorch-operator? @jian-he

I am not aware of it.

[jian-he]

Did we decided to use kubebuilder in tf-operator and pytorch-operator? @jian-he

no, we didn't. Just want to mention this scenario.

Yes, we still need to use informer etc. Just think should that reside in specific job controller's own implementation (the ones that require the informer structure) or still put it in the common API.

[gaocegege]

@jian-he Oh gotcha. Yeah it is the problem. Personally, I prefer keeping it in specific job controller. Or we will introduce something useless for kubebuilder use cases.

[johnugeorge]

agree with @gaocegege

[terrytangyuan]

Agreed. Then I think we can close this. WDYT? @sperlingxx

[sperlingxx]

Agreed. Then I think we can close this. WDYT? @sperlingxx

I close this now.