This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Remove the podControl and serviceControl interfaces #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
reviewed
May 13, 2019
| @@ -93,14 +93,14 @@ func (jc *JobController) ReconcileJobs( | |||
|
|
|||
| oldStatus := jobStatus.DeepCopy() | |||
|
|
|||
| pods, err := jc.GetPodsForJob(metaObject) | |||
| pods, err := jc.Controller.GetPodsForJob(job) | |||
There was a problem hiding this comment.
Do we need to specify Controller here? Interface embedding will do it for us, I think.
There was a problem hiding this comment.
that's due to the controller field is explicitly used in the struct.
this was there originally, we can remove it in a separate PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 14, 2020
georgkaleido
pushed a commit
to georgkaleido/common
that referenced
this pull request
Jun 9, 2022
* Remove encoding_kwargs PIL.Image.fromarray * Access im_rgb not via get Co-authored-by: Paul Angerer <dabauxi@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Removed the PodControl/ServiceControl interfaces.
Changed the associated logic accordingly
@richardsliu @gaocegege @johnugeorge
This change is