Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing GRPC health probe for arm64 to db-manager #1059

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Add missing GRPC health probe for arm64 to db-manager #1059

merged 1 commit into from
Feb 20, 2020

Conversation

MrXinWang
Copy link
Contributor

@MrXinWang MrXinWang commented Feb 19, 2020

In my previous PR #897 for the aarch64 platform support for katib Dockerfiles, the version of db-manager was v1alpha2, which has been deprecated now.

This PR adds the missing GRPC health probe binary to v1alpha3 aarch64 images.

Signed-off-by: Henry Wang <henry.wang@arm.com>


This change is Reviewable

Signed-off-by: Henry Wang <henry.wang@arm.com>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4fbf77d into kubeflow:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants