Enable arm64 architecture support for katib images and fix grpc health probe multiarch error. #897
Conversation
|
Hi @MrXinWang. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cc/ @gaocegege Please review. |
| apk --update add git gcc musl-dev && \ | ||
| go get github.com/grpc-ecosystem/grpc-health-probe && \ | ||
| mv $GOPATH/bin/grpc-health-probe /bin/grpc_health_probe && \ | ||
| chmod +x /bin/grpc_health_probe; \ |
There was a problem hiding this comment.
we suggest that grpc_health_probe should keep consistent in all kinds of platform.
Please refer to #893
There was a problem hiding this comment.
done :) shall I retest it?
|
/ok-to-test |
|
This PR contains changes in suggestion image build. While now our test infra has some problems on pip install and cannot build the suggestion image successfully. Would you mind testing and merging it after our new version 0.7 is released? (Maybe in several days) |
@gaocegege of course I don't mind, should I re-trigger the test or one of the reviewers will kindly do this for me? or should I propose another PR after you guys releasing the new version? Also, accroding to my understanding, the fix in testing infra would not affect the mergeablity of this patch, and since I have tested that the updated dockerfiles can be build successfully, therefore is there any possibility to merge this sooner? Thanks. |
|
When we are ready, I will comment in this PR. And you just need to rebase upstream master at that time.
We disabled the image build in CI, thus we cannot verify that it actually works. Ref 818b879#diff-7038d33999b797fcebe6cdfddd5806b7R23 Thus prefer rebasing and testing it when the CI is fixed if you do not mind. Thanks. And it should not be long. We will release today or tomorrow, I think. |
|
Ahhh ok, then take your time and I will wait. Thanks for your patience in explaining this :) |
|
Thanks for your patience, too. |
|
@MrXinWang Please rebase the master. |
|
@gaocegege Got it, thanks! |
|
@gaocegege still failing, is there any method to see the logs? Thanks |
| apt-get -y update && \ | ||
| apt-get -y install gfortran libopenblas-dev liblapack-dev && \ | ||
| pip install cython; \ | ||
| pip install cython 'numpy>=1.13.3'; \ |
There was a problem hiding this comment.
FYI: The reason why I added the pre-installation of numpy is that without this, when pip install -r requirements.txt, an error would occur on my arm64 machine saying that numpy should be installed first.
There was a problem hiding this comment.
Gotcha. Require @hougangliu 's review since I am not sure if it affects PPC.
|
Thanks for your contribution! 🎉 👍 |
|
@gaocegege sorry wait...I think a test is still running and based on my check on the details I dont think CI machine likes this (a v1alpha3 pod was failing).....I think the "/lgtm" label is too soon now. :) |
|
No worry, we need @hougangliu 's approve thus lgtm does not work, actually. |
|
testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-katib-presubmit-e2e-v1alpha3-S897-f19a6c2-6656-7188?tab=workflow I think it is caused by gcloud build. let's retest. /retest |
…h probe multiarch error. Change-Id: I5ddee7e8fbe96b8e0a025e3f182b4a5192c45597 Signed-off-by: Henry Wang <henry.wang@arm.com>
|
Hi @gaocegege! Solved the test failing problem and tests seem to be perfect now. Sorry for the inconvenience caused and thank you so much for your support as well as patience. |
| apt-get -y update && \ | ||
| apt-get -y install gfortran libopenblas-dev liblapack-dev && \ | ||
| pip install cython; \ | ||
| pip install cython 'numpy>=1.13.3'; \ |
There was a problem hiding this comment.
Gotcha. Require @hougangliu 's review since I am not sure if it affects PPC.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changed Dockerfiles and build scripts to support images on arm64, tested on both x86_64 machine and arm64 machine.
Followed by discussions with @gaocegege in feat: Add GRPC health check in suggestions #779 (comment), fixed problems of only have x86_64 version binary of grpc_health_probe in original Dockerfiles.
Change-Id: I5ddee7e8fbe96b8e0a025e3f182b4a5192c45597
Signed-off-by: Henry Wang <henry.wang@arm.com>
This change is