support ppc64le #893
support ppc64le #893
Conversation
|
cc/ @hougangliu Please review. |
| @@ -6,7 +6,11 @@ RUN if [ "$(uname -m)" = "ppc64le" ]; then \ | |||
| pip install cython; \ | |||
| fi | |||
| RUN GRPC_HEALTH_PROBE_VERSION=v0.3.0 && \ | |||
| wget -qO/bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \ | |||
| if [ "$(uname -m)" = "ppc64le" ]; then \ | |||
There was a problem hiding this comment.
please handle all grpc_health_probe version under cmd/suggestion v1alpha3
|
@hmtai thanks |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
This PR contains changes in suggestion image build. While now our test infra has some problems on pip install and cannot build the suggestion image successfully. Would you mind testing and merging it after 0.7? |
|
@gaocegege sure. never mind |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/test kubeflow-katib-presubmit |
|
Please rebase the master and let's see the CI result |
|
/lgtm |
Yes,rebase it just now. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #890
Special notes for your reviewer:
Release note:
This change is