-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Python version to 3.9 #1731
Bump Python version to 3.9 #1731
Conversation
ba710b0
to
2392b88
Compare
8ff0d76
to
56e5651
Compare
d5d6ed8
to
504d3c4
Compare
I added a new trial image as discussed in this comment but could not push it to ECR in CI. Do I need to create PR as this in kubeflow/testing repository? @kubeflow/wg-automl-leads |
Yes, please can you create PR with the new image:
|
Thank you for letting me know. @andreyvelich |
6fa3915
to
03bc04f
Compare
9692bfc
to
3561aac
Compare
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
30cc0bf
to
a08222a
Compare
I have rebased this PR and resolved conflicts. |
a08222a
to
6d74b60
Compare
6d74b60
to
a052149
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tenzen-y Please can you also update update-images.sh script with your new Trial image name. |
Sure. |
b63b40e
to
8553312
Compare
I have modified |
Thank you for driving this @tenzen-y! |
E2E sometimes fails in this PR by timeout.
2021/12/10 11:07:56 Waiting for Experiment tfjob-mnist-with-summaries to finish
2021/12/10 11:07:56 Experiment is running: 2 Trials, 0 Pending Trials, 1 Running Trials, 1 Succeeded Trials, 0 Failed Trials
2021/12/10 11:07:56 Current optimal Trial: {tfjob-mnist-with-summaries-mzdtdxhr [{learning_rate 0.014925334116019179} {batch_size 118}] {[{accuracy 0.9707 0.9707 0.9707}]}}
2021/12/10 11:07:56 Experiment conditions: [{Created True ExperimentCreated Experiment is created 2021-12-10 10:18:12 +0000 UTC 2021-12-10 10:18:12 +0000 UTC} {Running True Experi
mentRunning Experiment is running 2021-12-10 10:18:26 +0000 UTC 2021-12-10 10:18:26 +0000 UTC}]
2021/12/10 11:08:16 Deleting Experiment tfjob-mnist-with-summaries
2021/12/10 11:08:16 Wait Experiment finish failed: Experiment run timed out |
It looks like |
Should be good now, thanks @tenzen-y! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Upgrade the Python version and the dependent libraries version with that fix some training codes that stopped working after upgrading them and fix some dockerfile for arm64 and ppc64le that were not buildable.
Also, it allows the TFEventMetricsCollector to collect metrics generated by TF 2.X and, stop supporting TF <= 1.X.
Furthermore, add the task to kubeflow-katib-presubmit to verify that tfevent-metrics-collector can collect metrics output by training code using TF2.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1730
Checklist: