Implement validations for darts suggestion service #1926
Conversation
tenzen-y
force-pushed
the
implement-darts-validation-algorithm
branch
from
5ab03be
to
44dead9
Compare
Co-authored-by: Jaeyeon Kim(김재연) <anencore94@gmail.com>
Co-authored-by: Jaeyeon Kim(김재연) <anencore94@gmail.com>
|
@anencore94 https://github.com/kubeflow/katib/pull/1926/checks?check_run_id=7882927727 |
tenzen-y
force-pushed
the
implement-darts-validation-algorithm
branch
from
fc010cd
to
5d083e0
Compare
Thaks, I was signed in with different email, but now I signed with both email :) |
|
Looks good ! |
|
/hold until corrections are complete. |
|
Please take another look since I addressed all your review comments. @anencore94 /hold cancel |
tenzen-y
force-pushed
the
implement-darts-validation-algorithm
branch
from
5bc97d0
to
d338dd2
Compare
|
Thanks @tenzen-y /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anencore94, johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I implemented validations for the darts suggestion service.
Also, I commonalized a function to validate NAS operations as
pkg/suggestion/v1beta1/nas/common/validate.py.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part-of #1126
Checklist: