Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement validations for darts suggestion service #1926

Merged
merged 9 commits into from
Aug 18, 2022
Merged

Implement validations for darts suggestion service #1926

merged 9 commits into from
Aug 18, 2022

Commits on Aug 14, 2022

  1. implement validation for darts service

    @tenzen-y
    tenzen-y committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    44dead9 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Update pkg/suggestion/v1beta1/nas/darts/service.py 

    Co-authored-by: Jaeyeon Kim(김재연) <anencore94@gmail.com>
    @tenzen-y @anencore94
    tenzen-y and anencore94 authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    b3fb220 View commit details
    Browse the repository at this point in the history

  2. Update pkg/suggestion/v1beta1/nas/darts/service.py 

    Co-authored-by: Jaeyeon Kim(김재연) <anencore94@gmail.com>
    @tenzen-y @anencore94
    tenzen-y and anencore94 authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    7ed1f08 View commit details
    Browse the repository at this point in the history

  3. [review] delete todo comment

    @tenzen-y
    tenzen-y committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2af1307 View commit details
    Browse the repository at this point in the history

  4. [review] change function name validate_algorithm_settings to validate… 

    …_algorithm_spec
    @tenzen-y
    tenzen-y committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    9c6efdf View commit details
    Browse the repository at this point in the history

  5. [review] fix vaiolation comments

    @tenzen-y
    tenzen-y committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5d083e0 View commit details
    Browse the repository at this point in the history

  6. [review] fix condition to validate batch_size

    @tenzen-y
    tenzen-y committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    165592c View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. [review] add comment for developers

    @tenzen-y
    tenzen-y committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    5b190a4 View commit details
    Browse the repository at this point in the history

  2. [review] use set instead of list

    @tenzen-y
    tenzen-y committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    d338dd2 View commit details
    Browse the repository at this point in the history