Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change every reflect.DeepEqual to cmp.Diff, cmp.Equal for clarity #2288

Closed
wants to merge 8 commits into from

Conversation

Mu-Magdy
Copy link

@Mu-Magdy Mu-Magdy commented Mar 17, 2024

What this PR does / why we need it:
This PR solves the #2268 issue to change reflect.DeepEqual with cmp.Diff

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2268

Checklist:

  • Docs included if any changes are user facing

Copy link

google-cla bot commented Mar 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mu-Magdy
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Mu-Magdy and others added 7 commits March 17, 2024 06:36
Signed-off-by: Muhammed Magdy <muhammedmagdy1015@gmail.com>
* Upgrade Python version to 3.11

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Upgrade the numpy version to 1.25.2

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Increase resource requests for the ENAS suggestion service

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Update pytest CI

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Prepare dedicated pytest for skopt

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

---------

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Muhammed Magdy <muhammedmagdy1015@gmail.com>
Signed-off-by: Muhammed Magdy <muhammedmagdy1015@gmail.com>
Signed-off-by: Muhammed Magdy <muhammedmagdy1015@gmail.com>
@Mu-Magdy
Copy link
Author

solved previous problems

@tenzen-y
Copy link
Member

@Mu-Magdy Thank you for this contribution!
But, This is already taken by @tariq-hasan and he is working on it.
So, I'll close this PR. If you take another non-assigned issue, I'd appreciate it!

/close

@google-oss-prow google-oss-prow bot closed this Mar 17, 2024
Copy link

@tenzen-y: Closed this PR.

In response to this:

@Mu-Magdy Thank you for this contribution!
But, This is already taken by @tariq-hasan and he is working on it.
So, I'll close this PR. If you take another non-assigned issue, I'd appreciate it!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace reflect.DeepEqual with cmp.Diff in tests
2 participants