Fix using newer kustomize for knative-eventing-install #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidspek
force-pushed
the
knative-eventing-fix
branch
from
5617997 to
b4e1dfa
Compare
1 task
|
@davidspek thanks for your contribution! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidSpek, yanniszark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing with the latest version of kustomize the build for
common/knative/knative-eventing-install/basefails due to the usage of&ref_0and*ref_0in thematchLabelsandlabelssections respectively. While investigating I compared thedeployment.yamlof knative-eventing to that of knative-serving and noticed in the knative-serving manifests that the labels were explicitly stated. In the spirit of consistency and making the manifests usable with the latest version of kustomize this PR edits thedeployment.yamlof knative-eventing to use the same syntax as that of knative-serving./cc @yanniszark @PatrickXYS