Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Knative manifests to support newer kustomize versions #1806

Closed
wants to merge 1 commit into from
Closed

Update Knative manifests to support newer kustomize versions #1806

wants to merge 1 commit into from

Conversation

berndverst
Copy link
Member

Which issue is resolved by this Pull Request:
WIP for #1797

Description of your changes:

Kustomize 3.9.2 and beyond (including latest 4.X) does not seem to handle pointers / references in YAML anymore. Removing pointers appears to fix deployment problems with modern versions of Kustomize.

Can deploy with:

kustomize version
{Version:kustomize/v4.0.5 GitCommit:9e8e7a7fe99ec9fbf801463e8607928322fc5245 BuildDate:2021-03-08T20:53:03Z GoOs:darwin GoArch:amd64}
cd ~/src/berndverst/manifests/example
kustomize build --load-restrictor LoadRestrictionsNone .

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: berndverst
To complete the pull request process, please assign animeshsingh after the PR has been reviewed.
You can assign the PR to them by writing /assign @animeshsingh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@berndverst berndverst changed the title Support newer kustomize versions Update Knative manifests to support newer kustomize versions Apr 7, 2021
@davidspek
Copy link
Contributor

duplicate of #1795

@yanniszark
Copy link
Contributor

Thanks for the PR @berndverst!
Since this is a duplicate of #1795, let's continue the discussion there.

@yanniszark yanniszark closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants