-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pipeline-visualization-service to 0.1.31 #709
Upgrade pipeline-visualization-service to 0.1.31 #709
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @enriquedacostacambio. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/lgtm |
/lgtm |
/retest |
@enriquedacostacambio: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@IronPan are you able to access the tests logs for the failed test? Specifically |
The logs only show the same error as the presubmit test. |
@enriquedacostacambio it looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make generate-changed-only
and make test
not run. Please run them so that the unit tests are updated accordingly.
sorry for the very late reply. i see you already created a new pr, should i close this pr? or do you want me to fix the tests? |
Hey @enriquedacostacambio, no problem. This was actually resolved by #802. You can just close this PR. |
thanks! closed |
Which issue is resolved by this Pull Request:
Resolves kubeflow/pipelines#2806
Description of your changes:
Upgrades
pipeline-visualization-service
from0.1.27
to0.1.31
to matchapi-server
which is at0.1.31
and is not longer compatible with the older visualization service due to the change in the parameters format introduced by kubeflow/pipelines#1951Checklist:
cd manifests/tests
make generate-changed-only
make test
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)