Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pipeline-visualization-service to 0.1.31 #709

Conversation

enriquedacostacambio
Copy link

@enriquedacostacambio enriquedacostacambio commented Jan 16, 2020

Which issue is resolved by this Pull Request:
Resolves kubeflow/pipelines#2806

Description of your changes:
Upgrades pipeline-visualization-service from 0.1.27 to 0.1.31 to match api-server which is at 0.1.31 and is not longer compatible with the older visualization service due to the change in the parameters format introduced by kubeflow/pipelines#1951

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yanniszark
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @enriquedacostacambio. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enriquedacostacambio
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ajchili
Copy link
Member

ajchili commented Jan 17, 2020

/ok-to-test
/assign @IronPan
Hey @IronPan, there appears to be a version mismatch with the visualization server in our manifests file, this should resolve the issue. As an FYI I have not tested this yet but plan to once I get my cluster setup properly.

@ajchili
Copy link
Member

ajchili commented Jan 17, 2020

/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 17, 2020

/lgtm

@enriquedacostacambio
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@enriquedacostacambio: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-manifests-presubmit a3ced1b link /test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ajchili
Copy link
Member

ajchili commented Jan 21, 2020

@IronPan are you able to access the tests logs for the failed test? Specifically gs://kubernetes-jenkins/pr-logs/pull/kubeflow_manifests/709/kubeflow-manifests-presubmit/1219725160030932992/build-log.txt as seen on line 228 in the logs.

@ajchili
Copy link
Member

ajchili commented Jan 23, 2020

The logs only show the same error as the presubmit test.

@ajchili
Copy link
Member

ajchili commented Jan 28, 2020

@enriquedacostacambio it looks like the make generate-changed-only and make test commands did not work if you ran them. Can you confirm that they ran successfully? If you run into issues I can submit a PR for this with the tests ran.

Copy link
Member

@ajchili ajchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate-changed-only and make test not run. Please run them so that the unit tests are updated accordingly.

@enriquedacostacambio
Copy link
Author

sorry for the very late reply. i see you already created a new pr, should i close this pr? or do you want me to fix the tests?

@ajchili
Copy link
Member

ajchili commented Feb 16, 2020

Hey @enriquedacostacambio, no problem. This was actually resolved by #802. You can just close this PR.

@enriquedacostacambio
Copy link
Author

thanks! closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants