Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pipeline-visualization-service to 0.1.31 #808

Closed

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Jan 29, 2020

Which issue is resolved by this Pull Request:
Resolves kubeflow/pipelines#2806 and fixes issues in #709

Description of your changes:
Upgrades pipeline-visualization-service from 0.1.27 to 0.1.31 to match api-server which is at 0.1.31 and is not longer compatible with the older visualization service due to the change in the parameters format introduced by kubeflow/pipelines#1951.

This was originally done by @enriquedacostacambio within #709, but the tests were not update. This PR resolves that.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hougangliu
You can assign the PR to them by writing /assign @hougangliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ajchili
Copy link
Member Author

ajchili commented Jan 30, 2020

Superseded by #802.

@ajchili ajchili closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to generate visualization: Unable to initialize visualization
3 participants