Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-hardcode output paths in IBM components #4129

Closed
Ark-kun opened this issue Jul 2, 2020 · 6 comments · Fixed by #4647
Closed

De-hardcode output paths in IBM components #4129

Ark-kun opened this issue Jul 2, 2020 · 6 comments · Fixed by #4647
Assignees
Labels
area/components help wanted The community is welcome to contribute. status/triaged Whether the issue has been explicitly triaged

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 2, 2020

See the parent issue: #4100

Some components are using the deprecated fileOutputs attribute. See the query

The fileOutputs was deprecated from the start and should not be used in any non-legacy components.

We need to migrate from the deprecated fileOutputs to use the correct {outputPath: output_name} command-line placeholders instead.

Example:

Before:

implementation:
  container:
    command:
    - my_prog.py
    - --param1
    - value1
    fileOutputs:
      some_output: /some/hardcoded/path

After:

implementation:
  container:
    command:
    - my_prog.py
    - --param1
    - value1
    - --some-output
    - {outputPath: some_output}

The component code should be modified to receive all output paths through command-line arguments instead of hard-codong any paths.

An example of the correction: https://github.com/kubeflow/pipelines/pull/580/files#diff-9c31c4b41f436d2bbdfc9c97d40b9fe1
https://github.com/kubeflow/pipelines/pull/580/files#diff-ec0c67e038e3087e2bb01d439771bddc

@Ark-kun Ark-kun added help wanted The community is welcome to contribute. area/components labels Jul 2, 2020
@Bobgy Bobgy added the status/triaged Whether the issue has been explicitly triaged label Jul 3, 2020
@animeshsingh
Copy link
Contributor

/assign @Tomcli

@stale
Copy link

stale bot commented Oct 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 1, 2020
@stale
Copy link

stale bot commented Oct 10, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Oct 10, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Oct 10, 2020

/reopen
/frozen

@k8s-ci-robot k8s-ci-robot reopened this Oct 10, 2020
@k8s-ci-robot
Copy link
Contributor

@Bobgy: Reopened this issue.

In response to this:

/reopen
/frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 10, 2020
@jizg
Copy link

jizg commented Oct 19, 2020

@animeshsingh @Tomcli I think I can help on update the codes for this issue. But I may need some guide on how to do the tests for IBM components. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components help wanted The community is welcome to contribute. status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants