-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-hardcode output paths in IBM components #4129
Comments
/assign @Tomcli |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
/reopen |
@Bobgy: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@animeshsingh @Tomcli I think I can help on update the codes for this issue. But I may need some guide on how to do the tests for IBM components. Thanks. |
See the parent issue: #4100
Some components are using the deprecated
fileOutputs
attribute. See the queryThe
fileOutputs
was deprecated from the start and should not be used in any non-legacy components.We need to migrate from the deprecated
fileOutputs
to use the correct{outputPath: output_name}
command-line placeholders instead.Example:
Before:
After:
The component code should be modified to receive all output paths through command-line arguments instead of hard-codong any paths.
An example of the correction: https://github.com/kubeflow/pipelines/pull/580/files#diff-9c31c4b41f436d2bbdfc9c97d40b9fe1
https://github.com/kubeflow/pipelines/pull/580/files#diff-ec0c67e038e3087e2bb01d439771bddc
The text was updated successfully, but these errors were encountered: