De-hardcode output paths in all components

[Ark-kun]

Some components are using the deprecated fileOutputs attribute. See the query

The fileOutputs was deprecated from the start and should not be used in any non-legacy components.

We need to migrate from the deprecated fileOutputs to use the correct {outputPath: output_name} command-line placeholders instead.

Example:

Before:

implementation:
  container:
    command:
    - my_prog.py
    - --param1
    - value1
    fileOutputs:
      some_output: /some/hardcoded/path

After:

implementation:
  container:
    command:
    - my_prog.py
    - --param1
    - value1
    - --some-output
    - {outputPath: some_output}

The component code should be modified to receive all output paths through command-line arguments instead of hard-codong any paths.

An example of the correction: https://github.com/kubeflow/pipelines/pull/580/files#diff-9c31c4b41f436d2bbdfc9c97d40b9fe1
https://github.com/kubeflow/pipelines/pull/580/files#diff-ec0c67e038e3087e2bb01d439771bddc

There are two main groups of affected components:

• GCP components Issue: De-hardcode output paths in GCP components #4128 PR: chore(components): Components - De-hardcoded outputs paths in the GCP components. Fixes: #4128 #4123
• AWS components Issue: De-hardcode output paths in AWS components #4101 PR: [AWS SageMaker] De-hardcode output paths in AWS components #4119
• IBM components. Isssue: De-hardcode output paths in IBM components #4129
• The remaining few cases. PR: refactor(components): De-hardcoded local output paths. #580

[Bobgy]

@Ark-kun is this 1.0 release blocking?

Shall we add it to release notice? what kind of error message will people get if using this file_output?

[NikeNano]

@JohanWork

[Ark-kun]

fileOutputs was deprecated from the start. It was added to accommodate legacy containers that had hardcoded paths. No new components were supposed to use it.
I'll add a formal deprecation message: "The fileOutputs map is deprecated. Please use {outputPath: output_name} command-line placeholders instead.".
It won't be a hard error.

[Ark-kun]

is this 1.0 release blocking?

I do not think so. The components are not part of the release.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Bobgy]

/lifecycle frozen

[rimolive]

Looks like this work is done. Closing this issue.

/close

[google-oss-prow]

@rimolive: Closing this issue.

In response to this:

Looks like this work is done. Closing this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.