Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components): Components - De-hardcoded outputs paths in the GCP components. Fixes: #4128 #4123

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 1, 2020

Description of your changes:
Fixes #4128

Checklist:

  • The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

    PR titles examples:

    • fix(frontend): fixes empty page. Fixes #1234
      Use fix to indicate that this PR fixes a bug.
    • feat(backend): configurable service account. Fixes #1234, fixes #1235
      Use feat to indicate that this PR adds a new feature.
    • chore: set up changelog generation tools
      Use chore to indicate that this PR makes some changes that users don't need to know.
    • test: fix CI failure. Part of #1234
      Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@kubeflow-bot
Copy link

This change is Reviewable

@Ark-kun Ark-kun requested a review from Bobgy July 1, 2020 19:55
@Ark-kun Ark-kun changed the title Components - De-hardcoded outputs paths in the GCP components chore(components): Components - De-hardcoded outputs paths in the GCP components Jul 2, 2020
@Ark-kun Ark-kun marked this pull request as draft July 7, 2020 05:29
@Ark-kun Ark-kun force-pushed the Components---De-hardcoded-outputs-paths-in-the-GCP-components branch from fafc6c1 to c30112c Compare July 7, 2020 06:17
@Ark-kun Ark-kun marked this pull request as ready for review July 7, 2020 07:56
@Bobgy
Copy link
Contributor

Bobgy commented Jul 7, 2020

@googlebot

@Bobgy
Copy link
Contributor

Bobgy commented Jul 7, 2020

/lgtm

Thanks!

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 4, 2020

/test kubeflow-pipeline-postsubmit-standalone-component-test

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test kubeflow-pipeline-frontend-test
  • /test kubeflow-pipeline-backend-test
  • /test kubeflow-pipeline-e2e-test
  • /test kubeflow-pipeline-sample-test
  • /test kubeflow-pipeline-integration-test
  • /test kubeflow-pipeline-mkp-test
  • /test kubeflow-pipeline-upgrade-test
  • /test kubeflow-pipelines-sdk-python35
  • /test kubeflow-pipelines-sdk-python36
  • /test kubeflow-pipelines-sdk-python37
  • /test kubeflow-pipelines-sdk-python38
  • /test kubeflow-pipelines-tfx-python36
  • /test kubeflow-pipelines-component-yaml
  • /test kubeflow-pipelines-components-gcp-python27
  • /test kubeflow-pipelines-components-gcp-python37
  • /test kubeflow-pipelines-component-containers
  • /test kubeflow-pipelines-backend-visualization
  • /test kubeflow-pipeline-multiuser-test

Use /test all to run the following jobs:

  • kubeflow-pipeline-frontend-test
  • kubeflow-pipeline-backend-test
  • kubeflow-pipeline-e2e-test
  • kubeflow-pipeline-sample-test
  • kubeflow-pipeline-upgrade-test
  • kubeflow-pipelines-sdk-python35
  • kubeflow-pipelines-sdk-python36
  • kubeflow-pipelines-sdk-python37
  • kubeflow-pipelines-sdk-python38
  • kubeflow-pipelines-tfx-python36
  • kubeflow-pipelines-component-yaml
  • kubeflow-pipelines-components-gcp-python27
  • kubeflow-pipelines-components-gcp-python37
  • kubeflow-pipelines-component-containers

In response to this:

/test kubeflow-pipeline-postsubmit-standalone-component-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe6a10a into kubeflow:master Aug 4, 2020
chensun pushed a commit to chensun/pipelines that referenced this pull request Aug 7, 2020
@Ark-kun Ark-kun changed the title chore(components): Components - De-hardcoded outputs paths in the GCP components chore(components): Components - De-hardcoded outputs paths in the GCP components. Fixes: #4128 Sep 14, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

De-hardcode output paths in GCP components
7 participants