gcp-marketplace: Updating metadata deployment to use gRPC server #2083
Conversation
|
/retest |
| command: ["/bin/metadata_store_server"] | ||
| args: ["--grpc_port=8080", | ||
| "--mysql_config_host=mysql", | ||
| "--mysql_config_database=metadb", |
There was a problem hiding this comment.
could you revert this change? the db name need to be parameterized
{{ if .Values.managedstorage.databaseNamePrefix }}
- --mlmd_db_name={{ .Values.managedstorage.databaseNamePrefix }}_metadata
{{ else }}
- --mlmd_db_name={{ .Release.Name | replace "-" "_" | replace "." "_" | trunc 50 }}_metadata
{{ end }}
There was a problem hiding this comment.
@neuromage - This should be fine to use a custom database name correct? I remember you asking if we named the database as "metadb", not sure you asked because there is a dependency on the name somewhere or was it just for consistency.
There was a problem hiding this comment.
As per discussion, updated it.
@IronPan Is the syntax correct? I changed it add quotes, but let me know if its correct or needs modification.
There was a problem hiding this comment.
Syntax LGTM
Remove "--mysql_config_database=metadb" ?
There was a problem hiding this comment.
Arrg, my bad. Fixed it.
| @@ -4,7 +4,7 @@ images: | |||
| argoworkflowcontroller: gcr.io/ml-pipeline/workflow-controller:v2.3.0 | |||
| cloudsqlproxy: gcr.io/cloudsql-docker/gce-proxy:1.14 | |||
| frontend: gcr.io/ml-pipeline/frontend:0.1.27 | |||
| metadataserver: gcr.io/kubeflow-images-public/metadata:v0.1.8 | |||
| metadataserver: gcr.io/tfx-oss-public/ml_metadata_store_server:0.14.0 | |||
There was a problem hiding this comment.
Could you update here too https://github.com/kubeflow/pipelines/blob/master/.release.cloudbuild.yaml#L130
dushyanthsc
force-pushed
the
dushyanthsc/gcp-marketplace-helm
branch
from
748ced9 to
7b7f584
Compare
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-sample-test |
| command: ["/bin/metadata_store_server"] | ||
| args: ["--grpc_port=8080", | ||
| "--mysql_config_host=mysql", | ||
| "--mysql_config_database=metadb", |
There was a problem hiding this comment.
Syntax LGTM
Remove "--mysql_config_database=metadb" ?
| spec: | ||
| containers: | ||
| - name: container | ||
| image: gcr.io/ml-pipeline/envoy:initial |
There was a problem hiding this comment.
image for marketplace deployment need to parameterized. please follow other deployments and adjust the code.
There was a problem hiding this comment.
Updated it. Also looks like .release.cloudbuild.yaml also needs to be updated. I have added that as well.
dushyanthsc
force-pushed
the
dushyanthsc/gcp-marketplace-helm
branch
2 times, most recently
from
267d686 to
9ef2877
Compare
Change to update gcp marketplace helm charts to use gRPC MLMD metadata server.
dushyanthsc
force-pushed
the
dushyanthsc/gcp-marketplace-helm
branch
from
9ef2877 to
799337d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change to update gcp marketplace helm charts to use gRPC MLMD metadata server.
This change is