Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp-marketplace: Updating metadata deployment to use gRPC server #2083

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .release.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,19 @@ steps:
waitFor: ['pullVisualizationServer']

- name: 'gcr.io/cloud-builders/docker'
args: ['pull', 'gcr.io/kubeflow-images-public/metadata:v0.1.8']
args: ['pull', 'gcr.io/tfx-oss-public/ml_metadata_store_server:0.14.0']
id: 'PullMetadataServer'
- name: 'gcr.io/cloud-builders/docker'
args: ['tag', 'gcr.io/kubeflow-images-public/metadata:v0.1.8', 'gcr.io/ml-pipeline/google/pipelines/metadataserver:$TAG_NAME']
args: ['tag', 'gcr.io/tfx-oss-public/ml_metadata_store_server:0.14.0', 'gcr.io/ml-pipeline/google/pipelines/metadataserver:$TAG_NAME']
waitFor: ['PullMetadataServer']

- name: 'gcr.io/cloud-builders/docker'
args: ['pull', 'gcr.io/ml-pipeline/envoy:initial']
id: 'PullMetadataEnvoy'
- name: 'gcr.io/cloud-builders/docker'
args: ['tag', 'gcr.io/ml-pipeline/envoy:initial', 'gcr.io/ml-pipeline/google/pipelines/metadataenvoy:$TAG_NAME']
waitFor: ['PullMetadataEnvoy']

- name: 'gcr.io/cloud-builders/docker'
args: ['pull', 'gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z']
id: 'PullMinio'
Expand Down Expand Up @@ -222,5 +229,6 @@ images:
- 'gcr.io/ml-pipeline/google/pipelines/cloudsqlproxy:$TAG_NAME'
- 'gcr.io/ml-pipeline/google/pipelines/argoexecutor:$TAG_NAME'
- 'gcr.io/ml-pipeline/google/pipelines/argoworkflowcontroller:$TAG_NAME'
- 'gcr.io/ml-pipeline/google/pipelines/metadataenvoy:$TAG_NAME'

timeout: '1200s'
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,73 @@ spec:
app.kubernetes.io/name: {{ .Release.Name }}
spec:
containers:
- command:
- ./server/server
- --http_port=8080
- --mysql_service_host=mysql
- --mysql_service_port=3306
{{ if .Values.managedstorage.databaseNamePrefix }}
- --mlmd_db_name={{ .Values.managedstorage.databaseNamePrefix }}_metadata
{{ else }}
- --mlmd_db_name={{ .Release.Name | replace "-" "_" | replace "." "_" | trunc 50 }}_metadata
{{ end }}

image: {{ .Values.images.metadataserver }}
name: container
- name: container
image: {{ .Values.images.metadataserver }}
env:
- name: DBCONFIG_USER
valueFrom:
secretKeyRef:
name: mysql-credential
key: username
- name: DBCONFIG_PASSWORD
valueFrom:
secretKeyRef:
name: mysql-credential
key: password
command: ["/bin/metadata_store_server"]
args: ["--grpc_port=8080",
"--mysql_config_host=mysql",
{{ if .Values.managedstorage.databaseNamePrefix }}
'--mysql_config_database={{ .Values.managedstorage.databaseNamePrefix }}_metadata',
{{ else }}
'--mysql_config_database={{ .Release.Name | replace "-" "_" | replace "." "_" | trunc 50 }}_metadata',
{{ end }}
"--mysql_config_port=3306",
"--mysql_config_user=$(DBCONFIG_USER)",
"--mysql_config_password=$(DBCONFIG_PASSWORD)"
]
ports:
- containerPort: 8080
name: md-backendapi
---
kind: Service
apiVersion: v1
metadata:
labels:
app: metadata
app.kubernetes.io/name: {{ .Release.Name }}
name: metadata-envoy-service
spec:
selector:
component: metadata-envoy
type: ClusterIP
ports:
- port: 9090
protocol: TCP
name: md-envoy
---
apiVersion: apps/v1beta2
kind: Deployment
metadata:
name: metadata-envoy
labels:
component: metadata-envoy
app.kubernetes.io/name: {{ .Release.Name }}
spec:
replicas: 1
selector:
matchLabels:
component: metadata-envoy
template:
metadata:
labels:
component: metadata-envoy
spec:
containers:
- name: container
image: {{ .Values.images.metadataenvoy }}
ports:
- containerPort: 8080
name: md-backendapi
- name: md-envoy
containerPort: 9090
- name: envoy-admin
containerPort: 9901
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ images:
argoworkflowcontroller: gcr.io/ml-pipeline/workflow-controller:v2.3.0
cloudsqlproxy: gcr.io/cloudsql-docker/gce-proxy:1.14
frontend: gcr.io/ml-pipeline/frontend:0.1.27
metadataserver: gcr.io/kubeflow-images-public/metadata:v0.1.8
metadataserver: gcr.io/tfx-oss-public/ml_metadata_store_server:0.14.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

minio: gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z
mysql: gcr.io/ml-pipeline/mysql:5.6
persistenceagent: gcr.io/ml-pipeline/persistenceagent:0.1.27
proxyagent: gcr.io/ml-pipeline/inverse-proxy-agent:0.1.27
scheduledworkflow: gcr.io/ml-pipeline/scheduledworkflow:0.1.27
viewercrd: gcr.io/ml-pipeline/viewer-crd-controller:0.1.27
visualizationserver: gcr.io/ml-pipeline/visualization-server:0.1.27
metadataenvoy: gcr.io/ml-pipeline/envoy:initial

gcpSecretName: "user-gcp-sa"
serviceAccountCredential: null
Expand Down
4 changes: 4 additions & 0 deletions manifests/gcp_marketplace/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ x-google-marketplace:
properties:
images.cloudsqlproxy:
type: FULL
metadataenvoy:
properties:
images.metadataenvoy:
type: FULL
deployerServiceAccount:
roles:
- type: ClusterRole # This is a cluster-wide ClusterRole
Expand Down