Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new K8s version to improve workload identity stability #2777

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Dec 27, 2019

Try the new version with newer GKE metadata server (which relates to workload identity implementation) and see if it helps.

This change is Reviewable

@Bobgy Bobgy changed the title Use new K8s version to improve workload identity stability [WIP] Use new K8s version to improve workload identity stability Dec 27, 2019
@Bobgy Bobgy self-assigned this Dec 27, 2019
@Bobgy Bobgy force-pushed the test_wi_flakiness branch from ec26148 to 193b5a7 Compare December 27, 2019 06:28
@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 27, 2019

/test kubeflow-pipeline-sample-test
EDIT: tests passed

3 similar comments
@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 30, 2019

/test kubeflow-pipeline-sample-test
EDIT: tests passed

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 30, 2019

/test kubeflow-pipeline-sample-test
EDIT: tests passed

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 31, 2019

/test kubeflow-pipeline-sample-test
EDIT: tests passed

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 31, 2019

Ran 5 times, 4 times passed.
This seems better than existing flakiness rate.
I'll merge this.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title [WIP] Use new K8s version to improve workload identity stability Use new K8s version to improve workload identity stability Dec 31, 2019
@Bobgy Bobgy added the lgtm label Dec 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 76d6e56 into kubeflow:master Dec 31, 2019
@Bobgy Bobgy deleted the test_wi_flakiness branch December 31, 2019 05:09
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…ow#2777)

Signed-off-by: Luca Toscano <toscano.luca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants