Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sample tests] Upgrade GCP sdk to 272 in sample test #2786

Merged
merged 5 commits into from
Jan 2, 2020
Merged

[Sample tests] Upgrade GCP sdk to 272 in sample test #2786

merged 5 commits into from
Jan 2, 2020

Conversation

numerology
Copy link

@numerology numerology commented Dec 30, 2019 •
edited by jlewi
Loading

This change is Reviewable

@numerology
Copy link
Author

/assign @Bobgy
The tests are passing.
However the container_build sample test took very long to finish. Let me re-run it a couple of times to see if it's normal.

@numerology
Copy link
Author

/hold cancel

@numerology numerology changed the title [WIP] Upgrade GCP sdk to 272 in sample test [Sample tests] Upgrade GCP sdk to 272 in sample test Dec 31, 2019
@numerology
Copy link
Author

/test kubeflow-pipeline-sample-test

@numerology
Copy link
Author

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Dec 31, 2019

If packages interferes with each other, shall we consider using conda or virtual env to separate our python installation?

@numerology
Copy link
Author

If packages interferes with each other, shall we consider using conda or virtual env to separate our python installation?

Sounds good.

Before we proceed, may I know what's the initial motivation of upgrading SDK? It seems to me that it's still pretty flaky

@numerology
Copy link
Author

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Dec 31, 2019

Thanks, let me explain.
Initial motivation is

  • test real environment, it is recommended to use latest gcloud
  • workload identity was very flaky with gcloud 21x, so I upgraded all to 272, except this one
  • I would prefer all gcloud images are using the same version and we can freely change them.

@Bobgy
Copy link
Contributor

Bobgy commented Dec 31, 2019

I can first investigate observed flakiness here.
but I think it would still be helpful if we use conda, it means we can freely upgrade or downgrade without breaking test code

@Bobgy
Copy link
Contributor

Bobgy commented Dec 31, 2019

/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor

Bobgy commented Dec 31, 2019

I took a look at the error log, secret sample fails with connectivity issue. I think it's not related to this PR. It's because of workload identity's own issues.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 2, 2020 •
edited
Loading

Starting to verify flakiness change after efforts to reduce flakiness in #2777
/test kubeflow-pipeline-sample-test
EDIT: test passed

@Bobgy
Copy link
Contributor

Bobgy commented Jan 2, 2020

This supercedes #2744

@Bobgy Bobgy mentioned this pull request Jan 2, 2020
Closed
@Bobgy
Copy link
Contributor

Bobgy commented Jan 2, 2020 •
edited
Loading

/test kubeflow-pipeline-sample-test
EDIT: test passed

1 similar comment
@Bobgy
Copy link
Contributor

Bobgy commented Jan 2, 2020 •
edited
Loading

/test kubeflow-pipeline-sample-test
EDIT: test passed

@Bobgy
Copy link
Contributor

Bobgy commented Jan 2, 2020

@numerology
It seems flakiness problem is resolved. Shall we merge this version? You can install virtual env/conda in separate PR at the time you see fit (maybe next time when we need to upgrade gcloud version).

Try test last time: /test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor

Bobgy commented Jan 2, 2020

/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor

Bobgy commented Jan 2, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2cd3d6e into kubeflow:master Jan 2, 2020
@numerology numerology deleted the update-gcloud-sdk branch January 2, 2020 17:22
@Bobgy Bobgy mentioned this pull request Jan 3, 2020
Closed
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Jeffwan
[Sample tests] Upgrade GCP sdk to 272 in sample test (kubeflow#2786)
023abcd 
* try upgrade

* add back py-dev

* update install order

* add gcc

* remove TOOO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Bobgy Bobgy

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numerology @Bobgy @k8s-ci-robot