Changes for kfserving 0.4.1 #4479

juliusvonkohout · 2020-09-10T11:22:49Z

Description of your changes:

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

PR titles examples:
- fix(frontend): fixes empty page. Fixes #1234
  Use fix to indicate that this PR fixes a bug.
- feat(backend): configurable service account. Fixes #1234, fixes #1235
  Use feat to indicate that this PR adds a new feature.
- chore: set up changelog generation tools
  Use chore to indicate that this PR makes some changes that users don't need to know.
- test: fix CI failure. Part of #1234
  Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
Do you want this pull request (PR) cherry-picked into the current release branch?

If yes, use one of the following options:
- (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
- After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

google-cla · 2020-09-10T11:22:54Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

kubeflow-bot · 2020-09-10T11:22:54Z

This change is

k8s-ci-robot · 2020-09-10T11:22:59Z

Hi @juliusvonkohout. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-cla · 2020-09-10T11:25:00Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

juliusvonkohout · 2020-09-10T11:48:53Z

@googlebot I signed it!

animeshsingh

/lgtm

cc @Tomcli

Tomcli · 2020-09-10T18:43:39Z

Thanks @juliusvonkohout, can you also update this line to version 0.4.0 as well? I updated the 0.4.0 image to based on your branch.

pipelines/components/kubeflow/kfserving/component.yaml

Line 21 in 41dc386

image: aipipeline/kfserving-component:v0.3.0

Otherwise it looks good to me.

juliusvonkohout · 2020-09-12T19:32:11Z

Thanks @juliusvonkohout, can you also update this line to version 0.4.0 as well? I updated the 0.4.0 image to based on your branch.

pipelines/components/kubeflow/kfserving/component.yaml

Line 21 in 41dc386

image: aipipeline/kfserving-component:v0.3.0

Otherwise it looks good to me.

I have changed the version now.

Tomcli · 2020-09-14T16:07:31Z

/lgtm

Tomcli · 2020-09-14T16:07:47Z

/ok-to-test

stale · 2020-12-18T06:15:37Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

davidspek · 2021-02-02T18:52:19Z

@juliusvonkohout Does this need a refacotr for kfserving 0.4.1?

juliusvonkohout · 2021-02-06T18:48:38Z

@davidspek tehere are two places where 0.4.0 should be replaced with 0.4.1 and it should be rebased against master

juliusvonkohout · 2021-02-06T19:01:36Z

Thanks @juliusvonkohout, can you also update this line to version 0.4.0 as well? I updated the 0.4.0 image to based on your branch.

pipelines/components/kubeflow/kfserving/component.yaml

Line 21 in 41dc386

image: aipipeline/kfserving-component:v0.3.0

Otherwise it looks good to me.

i guess you have to update to 0.4.1 and build the image and test again. Feel free to make any edits.

Tomcli · 2021-02-08T17:47:54Z

components/kubeflow/kfserving/src/kfservingdeployer.py

        )
        print("Sample test commands: \n")
        # model_status['status']['url'] is like http://flowers-sample.kubeflow.example.com/v1/models/flowers-sample
+
+        host, path = url.sub("", model_status["status"]["address"]["url"]).split("/", 1)


Few weeks ago, we discovered that this split command may not work with some DNS for OpenShift route. So we removed it to avoid any confusion and error.

Tomcli · 2021-02-22T17:37:36Z

@juliusvonkohout the kubeflow-pipelines-component-yaml test is fixed now. Can you rebase this PR and remove the old changes from line 410-422? thanks

juliusvonkohout · 2021-02-22T20:30:28Z

@Tomcli I strongly hope that my resolve was correct. Someone should test this first.

Tomcli

@juliusvonkohout I have few comments for the rebase, thanks.

components/kubeflow/kfserving/src/kfservingdeployer.py

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>

juliusvonkohout · 2021-02-22T22:19:47Z

We should squash commit such that there are not so many garbage mini edits from me.

Tomcli · 2021-02-23T21:20:32Z

/lgtm
I added the 0.4.1 image tag for this component.yaml

Tomcli · 2021-02-23T21:21:32Z

@animeshsingh can you approve this PR? Thanks.

animeshsingh · 2021-02-24T20:16:35Z

/approve

google-oss-robot · 2021-02-24T20:16:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/kubeflow/kfserving/OWNERS~~ [animeshsingh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-02-24T20:17:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/kubeflow/kfserving/OWNERS~~ [animeshsingh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-02-24T20:17:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/kubeflow/kfserving/OWNERS~~ [animeshsingh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

juliusvonkohout · 2021-02-24T21:39:43Z

@Tomcli thank you very much for this effort. I already started to think that it will just be forgotten or is not compatible anymore.

Changes for kfserving 0.4.0

a44a61e

google-cla bot added the cla: no label Sep 10, 2020

k8s-ci-robot added the size/S label Sep 10, 2020

k8s-ci-robot added the needs-ok-to-test label Sep 10, 2020

k8s-ci-robot requested review from animeshsingh and Tomcli September 10, 2020 11:23

update to kfserving==0.4.0

e56d1d3

google-cla bot added cla: yes and removed cla: no labels Sep 10, 2020

animeshsingh reviewed Sep 10, 2020

View reviewed changes

k8s-ci-robot assigned animeshsingh Sep 10, 2020

k8s-ci-robot added the lgtm label Sep 10, 2020

Version 0.3.0 -> 0.4.0

13833a0

k8s-ci-robot removed the lgtm label Sep 12, 2020

k8s-ci-robot assigned Tomcli Sep 14, 2020

k8s-ci-robot added the lgtm label Sep 14, 2020

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Sep 14, 2020

stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Dec 18, 2020

stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Feb 2, 2021

Merge branch 'master' into patch-1

958005f

k8s-ci-robot removed the lgtm label Feb 6, 2021

juliusvonkohout added 2 commits February 6, 2021 19:57

Update Dockerfile

ef951c8

Update component.yaml

7f4e3b3

juliusvonkohout changed the title ~~Changes for kfserving 0.4.0~~ Changes for kfserving 0.4.1 Feb 6, 2021

Tomcli reviewed Feb 8, 2021

View reviewed changes

Tomcli mentioned this pull request Feb 8, 2021

feat(components): Added support for specifying Min and Max replicas for inference services #5059

Merged

chensun force-pushed the master branch 2 times, most recently from 7542f0e to 44d22a6 Compare February 12, 2021 09:23

Merge branch 'master' into patch-1

efcf8b4

Tomcli suggested changes Feb 22, 2021

View reviewed changes

components/kubeflow/kfserving/src/kfservingdeployer.py Outdated Show resolved Hide resolved

components/kubeflow/kfserving/src/kfservingdeployer.py Outdated Show resolved Hide resolved

juliusvonkohout and others added 2 commits February 22, 2021 23:13

Update components/kubeflow/kfserving/src/kfservingdeployer.py

f0df6a6

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>

Update kfservingdeployer.py

771fb75

google-oss-robot added the lgtm label Feb 23, 2021

google-oss-robot added the approved label Feb 24, 2021

google-oss-robot merged commit 65bed9b into kubeflow:master Feb 24, 2021

juliusvonkohout mentioned this pull request Nov 16, 2021

Add juliusvonkohout as kubeflow and kubeflow pipelines member kubeflow/internal-acls#509

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes for kfserving 0.4.1 #4479

Changes for kfserving 0.4.1 #4479

juliusvonkohout commented Sep 10, 2020 •

edited

Loading

google-cla bot commented Sep 10, 2020

kubeflow-bot commented Sep 10, 2020

k8s-ci-robot commented Sep 10, 2020

google-cla bot commented Sep 10, 2020

juliusvonkohout commented Sep 10, 2020

animeshsingh left a comment

Tomcli commented Sep 10, 2020

juliusvonkohout commented Sep 12, 2020

Tomcli commented Sep 14, 2020

Tomcli commented Sep 14, 2020

stale bot commented Dec 18, 2020

davidspek commented Feb 2, 2021

juliusvonkohout commented Feb 6, 2021

juliusvonkohout commented Feb 6, 2021 •

edited

Loading

Tomcli Feb 8, 2021

Tomcli commented Feb 22, 2021

juliusvonkohout commented Feb 22, 2021

Tomcli left a comment

juliusvonkohout commented Feb 22, 2021

Tomcli commented Feb 23, 2021

Tomcli commented Feb 23, 2021

animeshsingh commented Feb 24, 2021

google-oss-robot commented Feb 24, 2021

k8s-ci-robot commented Feb 24, 2021

k8s-ci-robot commented Feb 24, 2021

juliusvonkohout commented Feb 24, 2021

Changes for kfserving 0.4.1 #4479

Changes for kfserving 0.4.1 #4479

Conversation

juliusvonkohout commented Sep 10, 2020 • edited Loading

google-cla bot commented Sep 10, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

kubeflow-bot commented Sep 10, 2020

k8s-ci-robot commented Sep 10, 2020

google-cla bot commented Sep 10, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

juliusvonkohout commented Sep 10, 2020

animeshsingh left a comment

Choose a reason for hiding this comment

Tomcli commented Sep 10, 2020

juliusvonkohout commented Sep 12, 2020

Tomcli commented Sep 14, 2020

Tomcli commented Sep 14, 2020

stale bot commented Dec 18, 2020

davidspek commented Feb 2, 2021

juliusvonkohout commented Feb 6, 2021

juliusvonkohout commented Feb 6, 2021 • edited Loading

Tomcli Feb 8, 2021

Choose a reason for hiding this comment

Tomcli commented Feb 22, 2021

juliusvonkohout commented Feb 22, 2021

Tomcli left a comment

Choose a reason for hiding this comment

juliusvonkohout commented Feb 22, 2021

Tomcli commented Feb 23, 2021

Tomcli commented Feb 23, 2021

animeshsingh commented Feb 24, 2021

google-oss-robot commented Feb 24, 2021

k8s-ci-robot commented Feb 24, 2021

k8s-ci-robot commented Feb 24, 2021

juliusvonkohout commented Feb 24, 2021

juliusvonkohout commented Sep 10, 2020 •

edited

Loading

juliusvonkohout commented Feb 6, 2021 •

edited

Loading