Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for kfserving 0.4.1 #4479

Merged
merged 9 commits into from
Feb 24, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/kubeflow/kfserving/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM python:3.6-slim

RUN pip3 install kubernetes==10.0.1 kfserving==0.3.0 requests==2.22.0 Flask==1.1.1 flask-cors==3.0.8
RUN pip3 install kubernetes==10.0.1 kfserving==0.4.0 requests==2.22.0 Flask==1.1.1 flask-cors==3.0.8

ENV APP_HOME /app
COPY src $APP_HOME
Expand Down
10 changes: 5 additions & 5 deletions components/kubeflow/kfserving/src/kfservingdeployer.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
from kfserving import V1alpha2SKLearnSpec
from kfserving import V1alpha2XGBoostSpec
from kfserving.models.v1alpha2_onnx_spec import V1alpha2ONNXSpec
from kfserving import V1alpha2TensorRTSpec
from kfserving import V1alpha2TritonSpec
from kfserving import V1alpha2CustomSpec
from kfserving import V1alpha2InferenceServiceSpec
from kfserving import V1alpha2InferenceService
Expand Down Expand Up @@ -73,10 +73,10 @@ def EndpointSpec(framework, storage_uri, service_account):
service_account_name=service_account,
)
)
elif framework == "tensorrt":
elif framework == "triton":
return V1alpha2EndpointSpec(
predictor=V1alpha2PredictorSpec(
tensorrt=V1alpha2TensorRTSpec(storage_uri=storage_uri),
triton=V1alpha2TritonSpec(storage_uri=storage_uri),
service_account_name=service_account,
)
)
Expand Down Expand Up @@ -354,7 +354,7 @@ def update(kfsvc, model_name, namespace):
exit(1)
try:
print(
model_status["status"]["url"]
model_status["status"]["address"]["url"]
+ " is the knative domain header. $ISTIO_INGRESS_ENDPOINT are defined in the below commands"
)
print("Sample test commands: ")
juliusvonkohout marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -365,7 +365,7 @@ def update(kfsvc, model_name, namespace):
"ISTIO_INGRESS_ENDPOINT=$(kubectl -n istio-system get service istio-ingressgateway -o jsonpath='{.status.loadBalancer.ingress[0].ip}')"
)
# model_status['status']['url'] is like http://flowers-sample.kubeflow.example.com/v1/models/flowers-sample
host, path = url.sub("", model_status["status"]["url"]).split("/", 1)
host, path = url.sub("", model_status["status"]["address"]["url"]).split("/", 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few weeks ago, we discovered that this split command may not work with some DNS for OpenShift route. So we removed it to avoid any confusion and error.

print(
'curl -X GET -H "Host: ' + host + '" http://$ISTIO_INGRESS_ENDPOINT/' + path
juliusvonkohout marked this conversation as resolved.
Show resolved Hide resolved
)
Expand Down