-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): set correct permissions for local directory #7916
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @larrytin. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest-required |
@juliusvonkohout |
/retest |
@zijianjoy this is important for the 2.0 release then, because otherwise it would be a regression. |
What is required to merge this PR? I tested the changes in a restricted k8s environment (OpenShift) and these changes look good. With that, we and kfp-tekton team don't need to create SecurityContextContraint objects if this PR is merged. |
/lgtm |
@rimolive: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@rimolive You need to join the KFP meeting to push this PR. |
Thank you, Julius! I've been attending the meetings for a while. I will propose this PR to be reviewed next meeting. |
Same change has merged as #9946 |
same problem as #7213