Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test on Katib release branches #978

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

andreyvelich
Copy link
Member

Which issue is resolved by this Pull Request:
Related: kubeflow/katib#1774.

Description of your changes:
This PR allows tests on Katib release-0.13 branch

/assign @capri-xiyue @zijianjoy
/cc @gaocegege @johnugeorge

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

@zijianjoy
Copy link
Contributor

Will it make sense to use branches: ^master|release-.*$ ? So you don't need to create new PR every time.

@andreyvelich
Copy link
Member Author

Will it make sense to use branches: ^master|release-.*$ ? So you don't need to create new PR every time.

That's great idea, do you know does prow support that syntax ?

@zijianjoy
Copy link
Contributor

@andreyvelich andreyvelich changed the title Allow test on Katib release-0.13 branch Allow test on Katib release branches Jan 25, 2022
@andreyvelich
Copy link
Member Author

Taking a prow example from another repo: https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-postsubmits.yaml#L6

That makes sense, thanks!
I've made changes.

@zijianjoy
Copy link
Contributor

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 26, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fcacef9 into kubeflow:master Jan 26, 2022
@andreyvelich andreyvelich deleted the allow-test-katib-0.13 branch January 26, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants