Update the testing branches for kubeflow and manifests #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
zijianjoy
reviewed
Jan 26, 2022
| - master | ||
| - v1.3-branch | ||
| - v1.4-branch | ||
| - ^master|v.+$ |
There was a problem hiding this comment.
Should it be ^master|v.+-branch$? Otherwise it will trigger prow job on any branch starting with v.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
|
/lgtm |
theofpa
approved these changes
Jan 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, theofpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Refs kubeflow/manifests#2109
Description of your changes:
Updated prow to run the jobs on all release branches. Inspired by #978, but since we use
v1.5-branchnaming I think that the regex might not be as specific as for Katib. But it's a start./assign @zijianjoy
Checklist:
If PR related to Optional-Test-Infra,
aws/GitOpsfolder:cd awsmake optional-generatemake optional-test