fixed some golint warning #486
Conversation
|
/ok-to-test Thanks for your awesome contribution! Please fix the errors in travis build |
| @@ -24,7 +24,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error { | |||
| } | |||
|
|
|||
| // SetDefaultsTFJob initializes any uninitialized values to default values | |||
| func SetDefaults_TFJob(obj *TFJob) { | |||
| func SetDefaultsTFJob(obj *TFJob) { | |||
There was a problem hiding this comment.
I think we should not update the code here sine it is the convention for k8s defaulter-gen.
There was a problem hiding this comment.
I think we could revert the change here and set the file as ignored files in linter_config.json
There was a problem hiding this comment.
okay! sure I will revert the last commit and add that file in linter_config.json
There was a problem hiding this comment.
Thanks! Sorry for the late reply, or we could avoid the problem.
Thanks for your contribution, again.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fixed some golint warning * fixed some golint warning * updated linter_config.json
Signed-off-by: Ce Gao <gaoce@caicloud.io>
I have deleted my old PR since too many merge conflicts were occurring while rebasing the branch.
I have fixed some warnings as addressed by the issue. I have generated PR just to make sure that nothing is broken till now.
I have followed the convention as suggested by @jlewi .
This change is