-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: Use dep instead of glide and prune it #557
Conversation
1 similar comment
The error in Travis CI is fixed in #548 |
Why switch to dep instead of glide? We've been using glide in most places I think. /cc @wbuchwalter |
Because of #541 As you see, we reduced the code base significantly. + 27,065
- 1,698,564 Besides this, dep is more popular and avtive than glide: https://go.libhunt.com/compare-dep-vs-glide |
I don't have a strong oppinion but as I commented on the issue lets try to get consensus and adopt a single tool for all of Kubeflow. |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Per the discussion #556 , we come to an agreement. And I solved the problem in Travis, PTAL @jlewi @ScorpioCPH @zjj2wry |
/lgtm thank you do this ~ |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, zjj2wry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems that my approve does not work /assign @jlewi @ScorpioCPH |
* vendor: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * pkg: Regenerate Signed-off-by: Ce Gao <gaoce@caicloud.io> * update-codegen: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * vendor: Replace glide Signed-off-by: Ce Gao <gaoce@caicloud.io>
* vendor: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * pkg: Regenerate Signed-off-by: Ce Gao <gaoce@caicloud.io> * update-codegen: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * vendor: Replace glide Signed-off-by: Ce Gao <gaoce@caicloud.io>
dep prune -v
+27,065 −1,698,564
/assign @zjj2wry @jlewi
Close #556
This change is