Improve meta information in log messages to make it easier to debug jobs #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obs. * Use <namespace>.<name> as opposed to <namespace>/<name>; the former is more consistent with K8s style. * Add functions for constructing loggers for the pod and unstructured meta information. This will allow us to appropriately tag a number of log messages with meta information. * Update a bunch of log messages which weren't logging info with appropriate meta information. * Make json log formatting the default; this was the case for v1. json logging should be the default because otherwise we lose the meta information in the logs. With json logs its always possible to filter/reformat the log entries if you don't care about the metainformation. Related to: kubeflow#24 Use logrus kubeflow#635
jlewi
changed the title
|
/assign @gaocegege |
Travis tests have failedHey @jlewi, 2nd Buildgometalinter --config=linter_config.json --vendor ./...3rd Buildgometalinter --config=linter_config.json --vendor ./... |
|
/lgtm |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use . as opposed to /; the former
is more consistent with K8s style.
Add functions for constructing loggers for the pod and unstructured meta
information. This will allow us to appropriately tag a number of log
messages with meta information.
Update a bunch of log messages which weren't logging info with
appropriate meta information.
Make json log formatting the default; this was the case for v1.
json logging should be the default because otherwise we lose the meta
information in the logs. With json logs its always possible to filter/reformat
the log entries if you don't care about the metainformation.
Related to:
#24 Use logrus
#635
This change is