-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MPIJob unit tests to use spec.runPolicy.cleanPodPolicy #1556
Update MPIJob unit tests to use spec.runPolicy.cleanPodPolicy #1556
Conversation
Hi @cheimu. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheimu, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@terrytangyuan Hi Terry, It's weird, I don't know why tfjobs tests got failed for this pr. As you can see, except MPIJobs, this pr has nothing else been modified, so I don't know why this could lead to other jobs' unit tests failed. Any ideas? :/ Thank you in advance! |
New changes are detected. LGTM label has been removed. |
Pull Request Test Coverage Report for Build 2012430626
💛 - Coveralls |
Okay... Never minds, the unit tests got passed in the end :D |
What this PR does / why we need it:
This pr update mpijob unit tests: in the past, unit tests uses spec.cleanPodPolicy to test gc logic, but now in training-operator framework, spec.runPolicy.CleanPodPolicy is the standard, so it is more suit to use this field in unit tests as well.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1555
Checklist: