Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Remove Final Keyword from constants #1676

Merged

Conversation

andreyvelich
Copy link
Member

I think, we should remove Final keyword from our constants in Python SDK.
Final is available only in >= Python 3.8 version: https://peps.python.org/pep-0591/
Currently, we say that Training Operator SDK is supported in Python 3 and 3.7.
Also, it's better to be compatible with other Kubeflow components SDKs, e.g. with Kubeflow Pipelines.

We can think about Python upgrade in the future releases/versions across various Kubeflow components.

cc @johnugeorge @tenzen-y @anencore94

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3312804159

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 39.493%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 4 77.2%
Totals Coverage Status
Change from base Build 3289337304: -0.07%
Covered Lines: 2338
Relevant Lines: 5920

💛 - Coveralls

@johnugeorge
Copy link
Member

We have to soon upgrade
https://devguide.python.org/versions/

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 74655a1 into kubeflow:master Oct 24, 2022
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tenzen-y
Copy link
Member

We have to soon upgrade https://devguide.python.org/versions/

/lgtm /approve

I think that we need to upgrade the minimal support python version to v3.8 still releasing training-operator 1.6.0.

@andreyvelich andreyvelich deleted the sdk-remove-final-keyword branch October 24, 2022 14:56
@andreyvelich
Copy link
Member Author

I think that we need to upgrade the minimal support python version to v3.8 still releasing training-operator 1.6.0

@tenzen-y We might need to have discussion around this, because various Kubeflow SDKs should be compatible between each other.

@tenzen-y
Copy link
Member

I think that we need to upgrade the minimal support python version to v3.8 still releasing training-operator 1.6.0

@tenzen-y We might need to have discussion around this, because various Kubeflow SDKs should be compatible between each other.

Makes sense.
Or, we can stop supporting python v3.7 after 2023-06-27 which is EOL.

@anencore94
Copy link
Member

I agree with you guys, we need to move the minimal support to v3.8 or above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants