-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Remove Final Keyword from constants #1676
[SDK] Remove Final Keyword from constants #1676
Conversation
Pull Request Test Coverage Report for Build 3312804159
💛 - Coveralls |
We have to soon upgrade /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think that we need to upgrade the minimal support python version to v3.8 still releasing training-operator 1.6.0. |
@tenzen-y We might need to have discussion around this, because various Kubeflow SDKs should be compatible between each other. |
Makes sense. |
I agree with you guys, we need to move the minimal support to v3.8 or above |
I think, we should remove Final keyword from our constants in Python SDK.
Final is available only in >= Python 3.8 version: https://peps.python.org/pep-0591/
Currently, we say that Training Operator SDK is supported in Python 3 and 3.7.
Also, it's better to be compatible with other Kubeflow components SDKs, e.g. with Kubeflow Pipelines.
We can think about Python upgrade in the future releases/versions across various Kubeflow components.
cc @johnugeorge @tenzen-y @anencore94