Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor core/pod tests #1890

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I refactored core/pod tests to remove test_job dependencies.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #1816

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

coveralls commented Aug 20, 2023

Pull Request Test Coverage Report for Build 5917653729

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 42.777%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 5852486416: -0.01%
Covered Lines: 3737
Relevant Lines: 8736

💛 - Coveralls

@johnugeorge
Copy link
Member

@tenzen-y Thanks for this. There are other files that uses test job. Is it planned as a separate PR?

@tenzen-y
Copy link
Member Author

@tenzen-y Thanks for this. There are other files that uses test job. Is it planned as a separate PR?

Yes, I will work on other files at separate PRs because we need to refactor the whole of pod_control.

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 11b7a11 into kubeflow:master Aug 21, 2023
24 checks passed
@tenzen-y tenzen-y deleted the refactor-core-pod-test branch August 21, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants