Clean up the whole of training-operator

[tenzen-y]

After merging kubeflow/common into this repo, we have many redundant and duplicated codes in this repo.
So, we should clean up the whole of this repo.

• Replace dummy client with fake client: Replace dummy client with fake client #1818
• Remove TestJobController: Refactoring tests in common/controller.v1 #1843
• Organizing utils: Clean up /pkg/common/util/v1 #1845
• Remove Reconciler: Removing reconciler code #1879
• Completely remove test_job:

/kind cleanup

ref: #1813

cc: @johnugeorge @andreyvelich

[tenzen-y]

I take Remove TestJobController.

[tenzen-y]

/reopen

[google-oss-prow]

@tenzen-y: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[johnugeorge]

As utils are cleaned up, Is there something pending in this issue?

[tenzen-y]

As utils are cleaned up, Is there something pending in this issue?

@johnugeorge I think we need to decide how we handle the reconciler because the reconciler is dead codes.

[zw0610]

As utils are cleaned up, Is there something pending in this issue?

@johnugeorge I think we need to decide how we handle the reconciler because the reconciler is dead codes.

I think we can just remove the reconciler part.

[kuizhiqing]

@zw0610 This part aim to give a unified controller implementation which do not depend on specific kind of job, am I right ?
If so, the next version of real UNIFIED training operator would profit it.

[tenzen-y]

which do not depend on specific kind of job

@kuizhiqing Currently, this is the responsibility of the controller. The reconciler provides functionality the similar to the controller using the concept inspired by controller-runtime.

Although the reconciler's idea is much great, the reconciler is no longer maintained, a dead code.

So I would suggest removing the reconciler.
In the future, maybe we can implement common codes in a more controller-runtime native form.

[tenzen-y]

I added the last task, Completely remove test_job, to this issue description.

[tenzen-y]

/assign @tenzen-y @johnugeorge

[kuizhiqing]

@tenzen-y I think are aligned in this topic. I developed operators with controller-runtime heavily, so I think we do not fully take the advantage of it here. And I am agree with you that,

• we should remove reconciler here
• in the future we may introduce it with more native way

[tenzen-y]

@tenzen-y I think are aligned in this topic. I developed operators with controller-runtime heavily, so I think we do not fully take the advantage of it here. And I am agree with you that,

• we should remove reconciler here
• in the future we may introduce it with more native way

Yes, that's right. Thanks for being aligned.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tenzen-y]

/remove-lifecycle remove

I'm still working on the last piece.

[tenzen-y]

/remove-lifecycle stale

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[andreyvelich]

/good-first-issue
/help

[google-oss-prow]

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tenzen-y]

/remove-lifecycle stale