-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 1.1] Release Website 1.1 #1984
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
It looks like we might want to branch 1.0 on After that it looks like we start getting commits related to 1.1 |
Hi Jeremy, As soon as I get access to the repo I'll push that branch up. As far as netlify, is that automatic or are there any additional steps? |
@RFMVasconcelos
Please read: And please file PRs.
Is what automatic? |
Hi @jlewi, thank you for the guidance!!
I'm going through all the guidelines. Signed CLA, ready to start contributing :)
Will do! Started out with this one: #1999
I haven't used netlify before. Was wondering what I needed to know to render the website, or if it was automatic. |
Hey @RFMVasconcelos I left some suggestions in your PR #1999. (I'm not an official editor but a few things may need to be reviewed by you before the official PR review.) |
@RFMVasconcelos The website is automatically updated once PR is merged. Checkout the quickstart: https://github.com/kubeflow/website#quickstart When you create a PR it will automatically create preview for you of the rendered website. |
@jlewi Will you be open to accepting PRs about streamlining Kubeflow's Getting Started section? I think it was @LyleHenkeman who posted about it here. If you are open to improvements, I can work on it and submit a PR. @LyleHenkeman - I did spend a bit of time working through the steps because I was initially interested in the KF CLI and Pipelines, so I think I get why the current guide is a bit "busy". Cheers |
@8bitmp3 Yes; would you mind opening an issue and maybe outlining your changes before getting started on a PR? |
Next steps is to follow: To get the branch deployed |
The deployment on the
|
Not sure why that's only happening on the branch. We will need to get that fixed. |
#2001 is fixed. v1-0-branch is now serving There was an existing cname record For v1.0.kubeflow.org ; it was point at I updated it to point at the v1-0 branch There was a cname record for www.kubeflow.org pointing at 0.7; I updated it to point at master. I think we may need to change netlify to make the 1.0 branch the main branch. |
Giving a DNS error.
Lets give it a bit more time to propogate |
There is a typo in the CNAME record; there should be a trailing "/" on the value. I fixed that; still waiting for it to propogate. |
Returning 404 |
Filed a support request to the certificate updated; still no idea why I'm still getting 404s. |
Same, "Not Found". |
The 404 is fixed. Netlify told me that I had the subdomain name wrong; it needs to match the branch name so the cname record needs to be "v1-0-branch" This is now accessible but with an SSL error. Will ask Netlify to take care of the certificate |
Certificate should be fixed as well. |
At the meeting we decided we will flip over the website to the 1.1 docs as soon as the KFP docs are updated to reflect multi-user. @Bobgy Are the docs already updated for multiuser or can we get them updated. |
I have been writing docs full time in recent days. EDIT: tracking issue: kubeflow/pipelines#4317 |
I've also reviewed #2019 @RFMVasconcelos which is related to another PR of yours. |
KFP multi-user doc all clear |
@rui5i @8bitmp3 Now that the 1.0 branch is published we should be able to updown the version selector to include the 1.0 docs. Could one of you please send a PR to do that? |
@jlewi I'm sure @rui5i or I can assist 👍 Can you point us (especially me) to the steps in https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#updating-version-numbers-etc-for-the-upcoming-release-major-minor-or-patch ? Thank you for all the help |
@8bitmp3 Its step two updating config.toml |
Finished (final) review of KFP installation on kind, k3s and k3s on WSL (Windows) #2056 (review) |
@shawnzhu @adrian555 @vpavlin this page might need an update from your perspective |
@jlewi and @animeshsingh, do you know who are maintaining the istio and istio-dex? There are not v1.1.0 version for these two. If no plan to maintain a v1.1.0 version, I will have to use a different kfdef for the kfctl guide. |
@adrian555 Primary owners of the istio dex configs should be @krishnadurai and @yanniszark |
@8bitmp3 and @RFMVasconcelos Can we prioritize updating config.toml so the versions drop down shows the link to the 1.0 docs? Right now users can't find the 1.0 docs. Someone is asking about this in slack. |
[Issue: kubeflow/kubeflow#5022] [See also: kubeflow/website#1984]
[Issue: kubeflow/kubeflow#5022] [See also: kubeflow/website#1984]
* v1.1 istio dex components for kubernetes installation (#1494) * v1.1 istio dex components for kubernetes installation * Adds kfdef and creds correction * Test cases generated * v1.1.0 kfdef added (cherry picked from commit 6dcebbe) * v1.1 manifests for vanilla k8s (#1483) * v1.1 manifests for vanilla k8s * adds k8s_istio v3 kfdef * add tests (cherry picked from commit c429076) * Fix tests [Issue: kubeflow/kubeflow#5022] [See also: kubeflow/website#1984]
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…eflow#5084) * Update docs for releasing the website. related to kubeflow/website#1984 * Prune owners file as well.
…eflow#5084) * Update docs for releasing the website. related to kubeflow/website#1984 * Prune owners file as well.
Opening this issue to track doing a release of the website for Kubeflow 1.1
We still need to find an owner to drive this (see Release KF 1.1 kubeflow#5022)
The first step is cutting a 1.0 branch from master providing a stable link to the docs so we can begin updating the docs on master.
Docs for versioning the website: https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#version-the-website
The text was updated successfully, but these errors were encountered: