-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add v1.1 install instructions to vanilla k8s #2112
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kfctl_k8s_istio.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems manifest file here point to master. https://github.com/kubeflow/manifests/blob/316c3f16698fce5de8349daf1a59756aeaeec18a/kfdef/kfctl_k8s_istio.yaml#L340
Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pointer, totally missed that.
Let me make a PR to the manifests repo and get back to you
Pending merging of PR kubeflow/manifests#1484 |
To move things forward without our approval, I'd suggest setting up OWNERS file for |
Right, I would suggest finding more responsive folks for |
kfctl_istio_dex.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swiftdiaries should this be kfctl_istio_dex.v1.1.0.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed 🙌🏾
{{% alert title="Out of date" color="warning" %}} | ||
This guide contains outdated information pertaining to Kubeflow 1.0. This guide | ||
needs to be updated for Kubeflow 1.1. | ||
{{% /alert %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not updated yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the outdated badge
/assign @krishnadurai |
Confirming for KFP, did kfctl_istio_dex and kfctl_existing_k8s include KFP 1.0.0 with multi-user separation turned on? I think our early ideas is KFP multi-user is a key feature to release in Kubeflow 1.1, if a platform doesn't integrate it, it will not be qualified to be called as Kubeflow 1.1. |
Hey @Bobgy |
There's an open issue with how it can be used with Dex. I'm trying to give a bare-minimum setup that users can then customize by using the Dex API to get access multi-user KFP. I'm looking into the specific issues and ensure that the OOB KFDef works well soon |
Thank you @swiftdiaries for integrating with k8s_istio manifest! |
I'm merging this because it relates to the istio+dex config and the reviewers tagged aren't the right ones for this PR. |
Release docs for Kubeflow v1.1: #1984