Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v1.1 install instructions to vanilla k8s #2112

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Aug 12, 2020

Release docs for Kubeflow v1.1: #1984

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rmgogogo
You can assign the PR to them by writing /assign @rmgogogo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link

This change is Reviewable

kfctl_k8s_istio.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer, totally missed that.
Let me make a PR to the manifests repo and get back to you

@swiftdiaries
Copy link
Member Author

Pending merging of PR kubeflow/manifests#1484

@8bitmp3
Copy link
Contributor

8bitmp3 commented Aug 17, 2020

/assign @rmgogogo

(Since this "Needs approval from an approver in each of these files: OWNERS")

@Jeffwan @Bobgy If you or someone you know want to be added to OWNERS in docs/started/k8s/ let me know.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 18, 2020

To move things forward without our approval, I'd suggest setting up OWNERS file for content/en/docs/started/k8s/ and create a subfolder under shortcodes specific to k8s native deployment with an OWNERS file.

@PatrickXYS
Copy link
Member

Right, I would suggest finding more responsive folks for content/en/docs/started/k8s/

kfctl_istio_dex.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swiftdiaries should this be kfctl_istio_dex.v1.1.0.yaml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed 🙌🏾

{{% alert title="Out of date" color="warning" %}}
This guide contains outdated information pertaining to Kubeflow 1.0. This guide
needs to be updated for Kubeflow 1.1.
{{% /alert %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not updated yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the outdated badge

@rmgogogo rmgogogo requested a review from Bobgy August 18, 2020 23:37
@swiftdiaries
Copy link
Member Author

/assign @krishnadurai

@Bobgy
Copy link
Contributor

Bobgy commented Aug 19, 2020

Confirming for KFP, did kfctl_istio_dex and kfctl_existing_k8s include KFP 1.0.0 with multi-user separation turned on?

I think our early ideas is KFP multi-user is a key feature to release in Kubeflow 1.1, if a platform doesn't integrate it, it will not be qualified to be called as Kubeflow 1.1.
You may look at integration details in kubeflow/manifests#1364

@swiftdiaries
Copy link
Member Author

Hey @Bobgy
We've included the multi-user KFP in the kubernetes stack. Kustomization for the stack with multi-user KFP

@swiftdiaries
Copy link
Member Author

There's an open issue with how it can be used with Dex. I'm trying to give a bare-minimum setup that users can then customize by using the Dex API to get access multi-user KFP. I'm looking into the specific issues and ensure that the OOB KFDef works well soon

@Bobgy
Copy link
Contributor

Bobgy commented Aug 20, 2020

Thank you @swiftdiaries for integrating with k8s_istio manifest!

@swiftdiaries
Copy link
Member Author

I'm merging this because it relates to the istio+dex config and the reviewers tagged aren't the right ones for this PR.
I'll follow up with a PR for adding the appropriate OWNERS file

@swiftdiaries swiftdiaries merged commit 0772e13 into kubeflow:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants