Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an OWNERS file with approvers and reviewers for Kubeflow Azure docs #2199

Merged
merged 3 commits into from
Oct 10, 2020
Merged

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Sep 17, 2020

This PR creates an OWNERS file with approvers and reviewers for Kubeflow Azure docs.

It should help with the Issue and PR review process.

cc @aronchick (approver), @sudivate (reviewer) - let me know what you think. Should we add anyone else?

/assign @aronchick

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@8bitmp3: 1 invalid OWNERS file

In response to this:

This PR creates an OWNERS file with approvers and reviewers for Kubeflow Azure docs.

It should help with the Issue and PR review process.

cc @aronchick (approver), @sudivate (reviewer) - let me know what you think. Should we add anyone else?

/assign @aronchick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -0,0 +1,5 @@
approvers:
- aronchik
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 2: found character that cannot start any token.

@sudivate
Copy link
Contributor

@8bitmp3 please add @eedorenko to the list as well

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Sep 17, 2020

Ok @sudivate! I've just added @eedorenko as a second approver (just in case). Let me know what else I can help with

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Sep 21, 2020

@aronchick PTAL Thank you! We have an Azure doc PR that can benefit from this OWNERS file :)

@sudivate
Copy link
Contributor

sudivate commented Sep 29, 2020

@8bitmp3 any update on this, is #2196 blocked due to this?

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Sep 30, 2020

@aronchick @eedorenko Can you please take a look?

cc @Bobgy Do you know if you can assist here? If we get this done, we can help this Azure-related PR #2196 Thank you!

@eedorenko
Copy link

/assign eedorenko

@eedorenko
Copy link

/lgtm
/approve

Let's get it merged!

@eedorenko
Copy link

/assign @joeliedtke

@Bobgy
Copy link
Contributor

Bobgy commented Oct 10, 2020

Sorry, I'm just back from vacation.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, eedorenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8db7fec into kubeflow:master Oct 10, 2020
@8bitmp3 8bitmp3 deleted the patch-1 branch October 10, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants