-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an OWNERS file with approvers and reviewers for Kubeflow Azure docs #2199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@8bitmp3: 1 invalid OWNERS file
In response to this:
This PR creates an OWNERS file with approvers and reviewers for Kubeflow Azure docs.
It should help with the Issue and PR review process.
cc @aronchick (approver), @sudivate (reviewer) - let me know what you think. Should we add anyone else?
/assign @aronchick
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
content/en/docs/azure/OWNERS
Outdated
@@ -0,0 +1,5 @@ | |||
approvers: | |||
- aronchik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot parse file: error converting YAML to JSON: yaml: line 2: found character that cannot start any token.
@8bitmp3 please add @eedorenko to the list as well |
Ok @sudivate! I've just added @eedorenko as a second approver (just in case). Let me know what else I can help with |
@aronchick PTAL Thank you! We have an Azure doc PR that can benefit from this OWNERS file :) |
@aronchick @eedorenko Can you please take a look? cc @Bobgy Do you know if you can assist here? If we get this done, we can help this Azure-related PR #2196 Thank you! |
/assign eedorenko |
/lgtm Let's get it merged! |
/assign @joeliedtke |
Sorry, I'm just back from vacation. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, eedorenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR creates an OWNERS file with approvers and reviewers for Kubeflow Azure docs.
It should help with the Issue and PR review process.
cc @aronchick (approver), @sudivate (reviewer) - let me know what you think. Should we add anyone else?
/assign @aronchick