-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a list of approvers and reviewers for Upgrading Kubeflow docs #2257
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @jlewi fyi |
@8bitmp3 should we just delete these pages? These docs no longer looks relevant. KFUpgrade is no longer used. For GCP we are using GoogleCloudPlatform/kubeflow-distribution#103 to track upgrade instructions. |
@jlewi If you're OK with removing the whole section, we can do that (cc @RFMVasconcelos ). Then we together with OWNERS of each of the "subprojects" (AWS, IBM Cloud, Azure, Pipelines, etc) can start adding an From OWNERS files:
Other components... |
@8bitmp3 I think its sufficient for now to delete upgrading.md. We can leave it to the respective distribution owners to create their own upgrade documentation if and when they desire to. |
Agree to deleting upgrade.md doc, because the feature is no longer maintained. |
Given the deletion of the docs, I'll close this PR. /close |
@RFMVasconcelos: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Create a list of approvers and reviewers for Upgrading Kubeflow (deployment) docs - currently, there are none
@Bobgy Can you think of anyone else who works directly on the project and can approve the doc additions/changes here? Thank you!!
cc @RFMVasconcelos