Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a list of approvers and reviewers for Upgrading Kubeflow docs #2257

Closed
wants to merge 2 commits into from
Closed

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Oct 4, 2020

Create a list of approvers and reviewers for Upgrading Kubeflow (deployment) docs - currently, there are none

@Bobgy Can you think of anyone else who works directly on the project and can approve the doc additions/changes here? Thank you!!

cc @RFMVasconcelos

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobgy after the PR has been reviewed.
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Oct 4, 2020

cc @jlewi fyi

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Oct 4, 2020

We have a PR that may need an OK from an approver:

image

@rui-vas
Copy link
Contributor

rui-vas commented Oct 4, 2020

Hi @8bitmp3,

Thank you for bringing this up! 🚀

This is the same as #2219, but more advanced. I'll close #2219.

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Oct 5, 2020

@RFMVasconcelos Thanks for checking. As per PR 2219, I'll add @alfsuse

@Bobgy LMKWYT

@jlewi
Copy link
Contributor

jlewi commented Oct 6, 2020

@8bitmp3 should we just delete these pages?
https://www.kubeflow.org/docs/upgrading/upgrade/

These docs no longer looks relevant.
Going forward it probably makes sense to make the upgrade instructions specific to each deployment; e.g. the sections
Kubeflow on GCP
Kubeflow AWS
etc...
Can each have instructions specific to the deployment.

KFUpgrade is no longer used.

For GCP we are using GoogleCloudPlatform/kubeflow-distribution#103 to track upgrade instructions.

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Oct 6, 2020

@8bitmp3 should we just delete these pages?
https://www.kubeflow.org/docs/upgrading/upgrade/

These docs no longer looks relevant.

@jlewi If you're OK with removing the whole section, we can do that (cc @RFMVasconcelos ). Then we together with OWNERS of each of the "subprojects" (AWS, IBM Cloud, Azure, Pipelines, etc) can start adding an upgrading-kubeflow.md to their directories. WDYT?

cc @Bobgy @joeliedtke

From OWNERS files:

Other components...

@jlewi
Copy link
Contributor

jlewi commented Oct 8, 2020

@8bitmp3 I think its sufficient for now to delete upgrading.md. We can leave it to the respective distribution owners to create their own upgrade documentation if and when they desire to.

@Bobgy
Copy link
Contributor

Bobgy commented Oct 10, 2020

Agree to deleting upgrade.md doc, because the feature is no longer maintained.

@rui-vas
Copy link
Contributor

rui-vas commented Oct 17, 2020

Given the deletion of the docs, I'll close this PR.

/close

@k8s-ci-robot
Copy link
Contributor

@RFMVasconcelos: Closed this PR.

In response to this:

Given the deletion of the docs, I'll close this PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants