Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Google platform under /distributions #2547

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

rui-vas
Copy link
Contributor

@rui-vas rui-vas commented Mar 17, 2021

Following the latest discussions on platforms and distributions starting a PR to move Kubeflow on GCP.

cc @joeliedtke @Bobgy @animeshsingh

@rui-vas
Copy link
Contributor Author

rui-vas commented Mar 19, 2021

@joeliedtke could you please review this? I have made a similar request to all the platforms so we get them moved to distributions.

This is merging to master and we can make sure we only point the main website to master once all the platforms have moved, so there is no weird scenario where one of the clouds would be outside and others inside the distributions folder.

/assign @joeliedtke

cc @Bobgy

@Bobgy
Copy link
Contributor

Bobgy commented Mar 22, 2021

/lgtm
/approve
Thank you @RFMVasconcelos for helping with this!
I checked redirects quickly, seems all good. Because we are moving into master, I think we can get them in faster

Can you please resolve the conflicts?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, RFMVasconcelos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobgy,RFMVasconcelos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rui-vas
Copy link
Contributor Author

rui-vas commented Mar 22, 2021

Thank you @Bobgy ! I will fix the conflicts and merge then :)

@rui-vas
Copy link
Contributor Author

rui-vas commented Mar 22, 2021

@Bobgy I have fixed conflicts, can you please LGTM ?

@Bobgy
Copy link
Contributor

Bobgy commented Mar 22, 2021

/lgtm
Thank you!

@google-oss-robot google-oss-robot merged commit 6174ab8 into kubeflow:master Mar 22, 2021
thesuperzapper pushed a commit to thesuperzapper/website that referenced this pull request Mar 24, 2021
* move /gke folder to under /distributions

* update redirects

(cherry picked from commit 6174ab8)
google-oss-robot pushed a commit that referenced this pull request Apr 20, 2021
…rent `master` v2 (#2612)

* Create "Distributions" with kfctl + Kubeflow Operator (#2492)

* Create methods folder == section

* Move /operator under /methods

* Update links on Operator

* Add 'kfctl' folder == section

* mv kfctl specific minikube docs under /kfctl

* Update links on minikube

* mv kustomize from other-guides to /kfctl

* fix links for kustomize change

* delete outdated redirect

* move istio-dex-auth to /kfctl + rename to multi-user

* fix links after name change

* move kfctl install under /kfctl + rename to deployment

* fix links after move

* Add OWNERS for accountability

Update kfctl description

Update content/en/docs/methods/_index.md

* Add redirects for Operator

* Add redirects for kfctl

* Rename "methods" to "distributions"

* update redirects to distributions as folder name

* doc: Add instructions to access cluster with IBM Cloud vpc-gen2. (#2530)

* doc, Add instructions to access cluster with IBM Cloud vpc-gen2.

* added extra steps.

* Improved formatting

* Added details for creating cluster against existing VPC

* Apply suggestions from code review

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Formatting fixes, as per the review.

* Added a note about security.

* Choose between a classic or vpc-gen2 provider.

* added a note

* formatting fixes

* Apply suggestions from code review

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Document split up.

* Cleanup.

* Apply suggestions from code review

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>

* Formatting improvements and cleanup.

* format fixes

* Apply suggestions from code review

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>
Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>

* Add RFMVasconcelos to OWNERS/approvers (#2539)

* Deletes old redirects - pages do not exist anymore (#2552)

* Move `AWS` platform under /distributions (#2551)

* move /aws under /distributions

* fix AWS redirects + add catch-all

* update broken link (#2557)

* UPDATE fix broken links to tensoflorw serving (#2558)

* Move `Google` platform under /distributions (#2547)

* move /gke folder to under /distributions

* update redirects

* Move `Azure` platform under /distributions (#2548)

* mv /azure to /distributions

* add catch-all azure to redirects

* KFP - Update Python function-based component doc with param naming rules (#2544)

* Describe pipeline param naming

Adds notes on how the KFP SDK updates param names to describe the data instead of the implementation. Updates passing data by value to indicate that users can pass lists and dictionaries.

* Update auto-gen Markdown 

Updates python-function-components.md with changes to python-function-components.ipynb.

* Move `Openshift` platform under /distributions (#2550)

* move /openshift to under /distributions

* add openshift catch-all to redirects

* Move `IBM` platform under /distributions (#2549)

* move /ibm to under /distributions

* Add IBM catch-all to redirects

* [IBM] Update openshift kubeflow installation (#2560)

* Make kfctl first distribution (#2562)

* Move getting started on K8s page to under kfctl distribution (#2569)

* mv overview to under kfctl

* delete empty getting started with k8s section

* Add redirect to catch traffic

* Update GCP distribution OWNERS (#2574)

* Update KFP shortcodes OWNERS (#2575)

* Move MicroK8s to distributions (#2577)

* create microk8s folder in distributions

* move microk8s docs to distributions

* update title

* Add redirect for MicroK8s move - missed on #2577 (#2579)

* Add Charmed Kubeflow Operators to list of available Kubeflow distributions (#2578)

* Uplevel clouds for a level playing field

* Add Owners + Index of Charmed Kubeflow

* Add install page to Charmed Kubeflow distribution

* Link to Charmed Kubeflow docs

* Naming corrections

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Update content/en/docs/distributions/charmed/install-kubeflow.md

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* final fixes

Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>

* Fix broken link (#2581)

* IBM Cloud docs: update pipelines SDK setup for single-user (#2571)

Made the following changes to the instructions for setting
up the pipelines SDK for single-user.

* append '/pipeline' to the host string
* add client.list_experiments to make sure the setup is working,
consistent with the multi-user example in section 2
* add a note about KUBEFLOW_PUBLIC_ENDPOINT_URL since the user
may or may not have exposed the endpoint as a LoadBalancer

Signed-off-by: Chin Huang <chhuang@us.ibm.com>

* update broken links / tweak names (#2583)

* Move MiniKF to distributions (#2576)

* create minikf folde + index

* move minikf docs to minikf folder

* Add redirects for external links

* Change naming according to request

* update description minikf

* Clean up "Frameworks for training" + rename to "Training Operators" (#2584)

* Remove outdated banners from Pytorch and TF

* delete chainer

* order TF and pyT up

* rename "Frameworks for training" to "Training operators"

* Fix broken link (#2580)

* Remove "outdated" banners from MPI + MXnet operators (#2585)

* docs: Update MPI and MXNet operator pages (#2586)

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>

* Pin the version of kustomize, v4 is not supported. (#2572)

* Pin the version of kustomize, v4 is not supported.

There are issues installing Kubeflow with version v4. 

Note: 
#2570
https://github.com/kubeflow/kubeflow/issues/5755

* Add refrence to manifest repo version.

* Default to 3.2.0

* Update gke/anthos.md (#2591)

* fix broken link (#2603)

Co-authored-by: Prashant Sharma <prashsh1@in.ibm.com>
Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>
Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Co-authored-by: JohanWork <39947546+JohanWork@users.noreply.github.com>
Co-authored-by: Joe Liedtke <joeliedtke@google.com>
Co-authored-by: Mofizur Rahman <moficodes@gmail.com>
Co-authored-by: Yuan (Bob) Gong <4957653+Bobgy@users.noreply.github.com>
Co-authored-by: Chin Huang <chhuang@us.ibm.com>
Co-authored-by: brett koonce <koonce@gmail.com>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Co-authored-by: drPytho <filip@voiapp.io>
Co-authored-by: Ihor Sychevskyi <arhell333@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants