-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create "Distributions" with kfctl + Kubeflow Operator #2492
Conversation
Hey @8bitmp3! Could you please take a look into this PR? This creates the concept of "Methods & Distributions" as discussed in the last community meetings, to clarify what docs belong to what methods or distro. |
@RFMVasconcelos Catching up with PRs 🙏 See my comments above, LMKWYT. If you're happy with the links, I'm good and will LGTM |
Hey @8bitmp3 ! Thank you for the review! Let me take a look :) |
Nice catches! Accepted both suggestions :) |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Update kfctl description Update content/en/docs/methods/_index.md
@thesuperzapper @8bitmp3 I squashed commits so no action required. I think we're good to review and merge these. @joeliedtke @Bobgy would you be keen to take a look? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the Netlify configuration to use the 1.2 docs branch (we may need to create this branch) so these changes can be made without affecting the published docs until the 1.3 release. Once that change is in place, I will remove the hold and approve this PR. |
I've set up v1.2-branch in #2546. @RFMVasconcelos can you resolve the conflicts in this PR? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, RFMVasconcelos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've resolved the conflict @Bobgy, need a new LGTM now as I made changes. |
/lgtm |
* Create methods folder == section * Move /operator under /methods * Update links on Operator * Add 'kfctl' folder == section * mv kfctl specific minikube docs under /kfctl * Update links on minikube * mv kustomize from other-guides to /kfctl * fix links for kustomize change * delete outdated redirect * move istio-dex-auth to /kfctl + rename to multi-user * fix links after name change * move kfctl install under /kfctl + rename to deployment * fix links after move * Add OWNERS for accountability Update kfctl description Update content/en/docs/methods/_index.md * Add redirects for Operator * Add redirects for kfctl * Rename "methods" to "distributions" * update redirects to distributions as folder name (cherry picked from commit c792fe5)
…rent `master` v2 (#2612) * Create "Distributions" with kfctl + Kubeflow Operator (#2492) * Create methods folder == section * Move /operator under /methods * Update links on Operator * Add 'kfctl' folder == section * mv kfctl specific minikube docs under /kfctl * Update links on minikube * mv kustomize from other-guides to /kfctl * fix links for kustomize change * delete outdated redirect * move istio-dex-auth to /kfctl + rename to multi-user * fix links after name change * move kfctl install under /kfctl + rename to deployment * fix links after move * Add OWNERS for accountability Update kfctl description Update content/en/docs/methods/_index.md * Add redirects for Operator * Add redirects for kfctl * Rename "methods" to "distributions" * update redirects to distributions as folder name * doc: Add instructions to access cluster with IBM Cloud vpc-gen2. (#2530) * doc, Add instructions to access cluster with IBM Cloud vpc-gen2. * added extra steps. * Improved formatting * Added details for creating cluster against existing VPC * Apply suggestions from code review Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Formatting fixes, as per the review. * Added a note about security. * Choose between a classic or vpc-gen2 provider. * added a note * formatting fixes * Apply suggestions from code review Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Document split up. * Cleanup. * Apply suggestions from code review Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com> * Formatting improvements and cleanup. * format fixes * Apply suggestions from code review Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com> * Add RFMVasconcelos to OWNERS/approvers (#2539) * Deletes old redirects - pages do not exist anymore (#2552) * Move `AWS` platform under /distributions (#2551) * move /aws under /distributions * fix AWS redirects + add catch-all * update broken link (#2557) * UPDATE fix broken links to tensoflorw serving (#2558) * Move `Google` platform under /distributions (#2547) * move /gke folder to under /distributions * update redirects * Move `Azure` platform under /distributions (#2548) * mv /azure to /distributions * add catch-all azure to redirects * KFP - Update Python function-based component doc with param naming rules (#2544) * Describe pipeline param naming Adds notes on how the KFP SDK updates param names to describe the data instead of the implementation. Updates passing data by value to indicate that users can pass lists and dictionaries. * Update auto-gen Markdown Updates python-function-components.md with changes to python-function-components.ipynb. * Move `Openshift` platform under /distributions (#2550) * move /openshift to under /distributions * add openshift catch-all to redirects * Move `IBM` platform under /distributions (#2549) * move /ibm to under /distributions * Add IBM catch-all to redirects * [IBM] Update openshift kubeflow installation (#2560) * Make kfctl first distribution (#2562) * Move getting started on K8s page to under kfctl distribution (#2569) * mv overview to under kfctl * delete empty getting started with k8s section * Add redirect to catch traffic * Update GCP distribution OWNERS (#2574) * Update KFP shortcodes OWNERS (#2575) * Move MicroK8s to distributions (#2577) * create microk8s folder in distributions * move microk8s docs to distributions * update title * Add redirect for MicroK8s move - missed on #2577 (#2579) * Add Charmed Kubeflow Operators to list of available Kubeflow distributions (#2578) * Uplevel clouds for a level playing field * Add Owners + Index of Charmed Kubeflow * Add install page to Charmed Kubeflow distribution * Link to Charmed Kubeflow docs * Naming corrections * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Update content/en/docs/distributions/charmed/install-kubeflow.md Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * final fixes Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> * Fix broken link (#2581) * IBM Cloud docs: update pipelines SDK setup for single-user (#2571) Made the following changes to the instructions for setting up the pipelines SDK for single-user. * append '/pipeline' to the host string * add client.list_experiments to make sure the setup is working, consistent with the multi-user example in section 2 * add a note about KUBEFLOW_PUBLIC_ENDPOINT_URL since the user may or may not have exposed the endpoint as a LoadBalancer Signed-off-by: Chin Huang <chhuang@us.ibm.com> * update broken links / tweak names (#2583) * Move MiniKF to distributions (#2576) * create minikf folde + index * move minikf docs to minikf folder * Add redirects for external links * Change naming according to request * update description minikf * Clean up "Frameworks for training" + rename to "Training Operators" (#2584) * Remove outdated banners from Pytorch and TF * delete chainer * order TF and pyT up * rename "Frameworks for training" to "Training operators" * Fix broken link (#2580) * Remove "outdated" banners from MPI + MXnet operators (#2585) * docs: Update MPI and MXNet operator pages (#2586) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> * Pin the version of kustomize, v4 is not supported. (#2572) * Pin the version of kustomize, v4 is not supported. There are issues installing Kubeflow with version v4. Note: #2570 https://github.com/kubeflow/kubeflow/issues/5755 * Add refrence to manifest repo version. * Default to 3.2.0 * Update gke/anthos.md (#2591) * fix broken link (#2603) Co-authored-by: Prashant Sharma <prashsh1@in.ibm.com> Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com> Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com> Co-authored-by: JohanWork <39947546+JohanWork@users.noreply.github.com> Co-authored-by: Joe Liedtke <joeliedtke@google.com> Co-authored-by: Mofizur Rahman <moficodes@gmail.com> Co-authored-by: Yuan (Bob) Gong <4957653+Bobgy@users.noreply.github.com> Co-authored-by: Chin Huang <chhuang@us.ibm.com> Co-authored-by: brett koonce <koonce@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: drPytho <filip@voiapp.io> Co-authored-by: Ihor Sychevskyi <arhell333@gmail.com>
PR to tackle issue #2489, as part of the Kubeflow docs restructuring project.