-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the "Getting Started" "Installing Kubeflow" page #2590
Comments
@RFMVasconcelos there are quite a lot of renames here, but I think it will make the user experience easier. I have used |
Thank you for getting this process started @thesuperzapper! This is going to make things much more clear to users 🚀 I like the majority of the proposal! Leaving a few comments:
|
@RFMVasconcelos I agree with all your comments above. I would rename Also, it may make sense for all the tables to go to the distributions page and leave here only a link to the distributions page, same as we do for Path 1, so the user doesn't have to scroll a lot, but I'll let you decide on this. Thanks! |
Looking at my previous proposal + @cvenets comments one option would be:
@cvenets maybe // note 1: I moved MicroK8s from platform-specific to multi-platform, because being a small K8s, it can be run on multiple platforms. // Issue 1: I would like to have a way to show users on e.g. @thesuperzapper WDYT? |
@RFMVasconcelos I agree with all your comments and notes. Wrt to the issue, I agree as well. The only two ways I can think of are:
I'm not sure I can think of something to add on the first section, but maybe someone has an idea for this as well. |
@RFMVasconcelos note that we need to remove the kfctl entry from this page:
Take a look at #2604, which @castrojo just provided after today's update on kubeflow/manifests#1798 from vendors, where both Cisco and Arrikto dropped support for kfctl, and thus all corresponding docs become obsolete and out-of-date for 1.3. |
@RFMVasconcelos
I think we should call the two paths:
I was thinking something like this for the distribution tables. Platform-specific distributions:
Multi-platform distributions:
NOTE:
I am happy to have a crack at a PR it unless you really want to. |
@thesuperzapper please note the following:
This isn't really the case, since MiniKF is already available as a VM image on AWS Marketplace, GCP Marketplace, Vagrant Cloud, and will be coming on Microsoft platforms as well. The fact that it is packaged in an image doesn't really change its multi-platform nature.
This doesn't hold. The Manifests WG maintain and guarantee that these instructions should work, so it is definitely supported. |
Re MiniKF: I think its probably better to remove the distinction, and add a column to clarify, for example:
Re the warning: What I am trying to say is that users should not expect any environment-specific support from the Kubeflow Community for the "roll your own" path |
Thank you @cvenets and @thesuperzapper for the comments on this front and for creating the WIP PR! A few comments on your proposing table @thesuperzapper:
I have (PS: @cvenets I deleted one comment from you because it was repeated) |
I agree, a single table is fine with the addition of the last column. I agree with @RFMVasconcelos on 2. We don't want people to go off the website or confuse them. A single link to the corresponding docs should suffice. I will comment on the PR as well.
@thesuperzapper OK, this makes sense then, but I think this is pretty clear by the "on your own" part of the title of the section. |
@thesuperzapper For ArgoFlow I think the target should be |
@thesuperzapper (and @davidspek) I love the energy behind ArgoFlow, but I feel a bit wary of adding it directly here as per your proposal. According to #2611, the way you propose this table is to link the ArgoFlow documentation to its own repo. I am not sure what is the right way to proceed here. If creating appropriate docs in Kubeflow for this distribution and point from here. I would overall want to make sure that the goal of this page as a gateway and map to Kubeflow docs is met. I would suggest tackling this specific issue on a separate thread, making structure independent from content. WDYT? |
I agree with @RFMVasconcelos. All links in this page should redirect to Kubeflow docs, not external sites. |
@RFMVasconcelos @cvenets regarding comment that we should only link to kubeflow.org docs I actually think we should do the opposite (over time), just as kubernetes.io doesn't host EKS docs, we shouldn't host vendor specific docs, but rather link to parter websites. This will do a few things:
NOTE: This is not about the structure of the table, I agree with comments about improving how the links are displayed, and will update the PR |
/reopen
ref: #2611 (comment) |
@Bobgy: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
and some ideas for further improvement:
|
the immediate problems are fixed by #2635 Where do you plan to create a new issue tracking future improvements? Or shall we keep the discussion here? |
@Bobgy lets make specific issues for any changes we want to make/discuss and close this out. |
As we have been moving all distribution-specific docs out of "Getting Started" with PRs like #2576, #2577, #2569, #2492, we should now clean up the first place people look when trying to install Kubeflow.
As proposed by @cvenets here we should clearly indicate the two "paths" for installing Kubeflow:
kubeflow/manifests
yourself, with no supportI think this leaves us with the following sections in "Getting Started" / "Installing Kubeflow":
The text was updated successfully, but these errors were encountered: