Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename getting started to fix broken link #2635

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

rui-vas
Copy link
Contributor

@rui-vas rui-vas commented Apr 22, 2021

Fixes #2634

@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RFMVasconcelos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rui-vas
Copy link
Contributor Author

rui-vas commented Apr 22, 2021

[URGENT] - @castrojo @thesuperzapper I need a LGTM here to merge this. The title change broke the master branch (glad we are not pointing to it yet!)

@davidspek
Copy link
Contributor

/lgtm

@rui-vas
Copy link
Contributor Author

rui-vas commented Apr 22, 2021

Thank you @davidspek ! With urgency we did not test the branch and it got broken. Hopefully this fixes it. Testing now

@Bobgy
Copy link
Contributor

Bobgy commented Apr 22, 2021

thanks, makes sense to me.

keep in mind that any proper file rename needs

  • fixing existing links
  • adding redirect rules

@thesuperzapper
Copy link
Member

@RFMVasconcelos should we rename this to installing-kubeflow, and add a redirect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key link broken!
5 participants