Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor "Installing Kubeflow" page #2611

Merged

Conversation

thesuperzapper
Copy link
Member

Closes #2590

As discussed in Issue #2590, this is a rewrite for the "Installing Kubeflow" page.

@thesuperzapper
Copy link
Member Author

@RFMVasconcelos @cvenets

content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
Copy link
Member

@joeliedtke joeliedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions

content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
@shannonbradshaw
Copy link
Contributor

shannonbradshaw commented Apr 19, 2021

@joeliedtke I think maybe you want to take a look at my PR instead. Most of what you're commenting on, I've already fixed on here: #2625

@thesuperzapper
Copy link
Member Author

@RFMVasconcelos @joeliedtke I have made changes based off the comments, any further thoughts?

After we agree on the bullet points under each section, we can write the actual text.

@Bobgy Bobgy mentioned this pull request Apr 20, 2021
Copy link
Contributor

@rui-vas rui-vas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesuperzapper thank you for leading this! I have left a few comments throughout :)

content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
@rui-vas
Copy link
Contributor

rui-vas commented Apr 21, 2021

@thesuperzapper Thank you for your last commits, this is shaping up to be a great overview! 🎉

Please see this comment. Aside from that, I think we are ready to write the missing descriptions and effectively merge this. WDYT?

Copy link
Contributor

@rui-vas rui-vas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shannonbradshaw I think we should update this page centrally here. I have adapted pieces from your #2625 PR to complete this one so we can maximize output and take advantage of everyone's willingness to contribute.

@thesuperzapper can you review the text proposals and, with your edits, commit so we can get to a final PR?

content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
@shannonbradshaw
Copy link
Contributor

@shannonbradshaw I think we should update this page centrally here. I have adapted pieces from your #2625 PR to complete this one so we can maximize output and take advantage of everyone's willingness to contribute.

@RFMVasconcelos sounds good! Thanks for all the work, @thesuperzapper and @RFMVasconcelos.

@thesuperzapper thesuperzapper changed the title [WIP] refactor of "Installing Kubeflow" refactor "Installing Kubeflow" page Apr 22, 2021
@thesuperzapper
Copy link
Member Author

@RFMVasconcelos I have incorporated your suggestions, and I think this is ready to /approve.

Obviously we will iterate on this page, but we should try and get this merged very soon, so it can be linked to in the 1.3 blogs.

@shannonbradshaw
Copy link
Contributor

shannonbradshaw commented Apr 22, 2021

@thesuperzapper Arrikto Enterprise Kubeflow should be listed among the distributions. Asking that we include at:
distributions/ekf/_index.md

with the text below

`+++
title = "Arrikto Enterprise Kubeflow"
description = "Kubeflow distribution with additional automation, reproducibility, portability, and security features"
weight = 50
+++

The Arrikto Enterprise Kubeflow (EKF) distribution extends the capabilities of the Kubeflow platform with additional automation, reproducibility, portability, and security features.

  • Automation: Orchestrate your end-to-end ML workflow with a click of a button. Start by tagging cells in Jupyter Notebooks to define pipeline steps, hyperparameter tuning, GPU usage, and metrics tracking. Click a button to create pipeline components and KFP DSL, resolve dependencies, inject data objects into each step, deploy the data science pipeline, and serve the best model. Or use the Kale SDK to do all the above with your preferred IDE.
  • Reproducibility: Snapshot pipeline code, libraries, and data for every step with Arrikto’s Rok data management platform. Roll back to any machine learning pipeline step at it’s exact execution state for easy debugging. Collaborate with other data scientists through a Git-style publish/subscribe versioning workflow.
  • Portability: Deploy and upgrade your Kubeflow environment with a proven GitOps process across all major public clouds, and on-prem infrastructure. Move ML workflows seamlessly across with Rok Registry.
  • Security: Manage teams and user access via GitLab or any ID provider via Istio/OIDC. Isolate user ML data access within their own namespace while enabling notebook and pipeline collaboration in shared namespaces. Manage secrets and credentials securely, and efficiently.
    `

@shannonbradshaw
Copy link
Contributor

shannonbradshaw commented Apr 22, 2021

@thesuperzapper the column values for the table entry for the EKF distribution should be:
Arrikto Enterprise Kubeflow | Arrikto | EKS, AKS, GKE | link to page created using text from my previous comment

Copy link
Contributor

@shannonbradshaw shannonbradshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesuperzapper, requesting a few changes.

content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
</tr>
<tr>
<td>Kubeflow on Openshift</td>
<td>IBM Cloud</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red Hat

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, this distribution is maintained by IBM Cloud, (not RedHat) @animeshsingh can verify.

content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
content/en/docs/started/installing-kubeflow.md Outdated Show resolved Hide resolved
<td>Cloud Marketplaces, Vagrant</td>
<td><a href="/docs/distributions/minikf/">Docs</a></td>
<td></td>
</tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<tr> <td><a href="/docs/distributions/ekf/">Arrikto Enterprise Kubeflow</a></td> <td>Arrikto</td> <td>EKS, AKS, GKE </td> </tr>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep this PR to refactoring what was already there, if you want to add another doc page, you can just raise a PR which updates the "Installing Kubeflow" page, after this has been merged.

@thesuperzapper
Copy link
Member Author

@shannonbradshaw you mentioned wanting to add the "Arrikto Enterprise Kubeflow" distribution, please raise a separate PR (after this one is merged), as this PR is only for refactoring the "Installing Kubeflow" page, not adding a new distribution doc.

@thesuperzapper
Copy link
Member Author

@RFMVasconcelos I think this is good enough to merge now so we have a proper "Installing Kubeflow" page up by the time 1.3 is dropped tonight.

We can keep iterating on it over the next while if needed.

Copy link
Contributor

@rui-vas rui-vas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesuperzapper @shannonbradshaw for the interest of time I agree with @thesuperzapper that we should merge this and then keep on iterating in further PRs.

For reference, this will merge to the master branch. For these changes to be effective we need @Bobgy or @joeliedtke to change the config in netlify so that the website points to that branch.

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RFMVasconcelos, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 20d53c6 into kubeflow:master Apr 22, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Apr 22, 2021

Adding some late comments:

  1. [blocker] I think we are missing a redirect rule from the old page to the new page
  2. [blocker] https://deploy-preview-2611--competent-brattain-de2d6d.netlify.app/docs/started/getting-started/ is broken, we should update the "getting started" button url
  3. the link to manifest README should better pin to 1.3.0 release once we pin the final release
  4. I think we should add a column "Issue Tracker" where people can report distribution specific issues.

EDIT: 1 and 2 already fixed by #2635

@Bobgy
Copy link
Contributor

Bobgy commented Apr 22, 2021

I really love where this is going and appreciate the efforts!
Thank you @thesuperzapper @shannonbradshaw @RFMVasconcelos!

@rui-vas
Copy link
Contributor

rui-vas commented Apr 22, 2021

Sorry if I prematurely merged this one @Bobgy, but wanted to accelerate the progress, allowing iteration in further PRs. :)

Blockers:

  1. I noticed and fixed this in rename getting started to fix broken link #2635, was a BIG problem 😂
  2. Also fixed in rename getting started to fix broken link #2635 (I think, please verify :) )
  3. +1
  4. +1 - too many columns may wrap but I think this would be useful! We can find a sensible way to make it fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the "Getting Started" "Installing Kubeflow" page
7 participants