-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ekf distro #2641
Add ekf distro #2641
Conversation
Hi @shannonbradshaw. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@RFMVasconcelos can you please merge the above PR today? This is fully supported by Arrikto, tested and validated for 1.3, so it needs to be in the distributions table for people to be able to find it, before 1.3 gets announced. |
@RFMVasconcelos we have a precedent for adding distros that members of the community are actively maintaining. Argoflow is just one example. It is arbitrary to exclude Arrikto EKF at this point. I'd asked to have this included in #2611 and you and @thesuperzapper asked me to file a separate PR. Here it is. I would appreciate getting this merged in time for the release announcement. I have not heard any specific objections to including this so there does not seem to be a reason to hold off. On top of all that, given the effort on this release by the entire Arrikto team, I think we've earned the right to have Arrikto Enterprise Kubeflow listed in the distros table. It's up to date for 1.3. cc: @Bobgy |
213a8d1
to
beba237
Compare
@shannonbradshaw to be honest, I feel uncomfortable making this decision on my own without a community agreement. |
@RFMVasconcelos what, specifically, would you take as community agreement? Also, I'm not sure I understand the hesitation. We seem to have made the decision about Argoflow without community agreement. |
I don't see any significant issues with including this distribution in the docs. Clearly, once we have resolve Kubeflow's governance issues, and then setup a distribution validation system, this list will surely change anyway. @RFMVasconcelos @Bobgy from a logistical perspective one of you will have to /approve this. But @shannonbradshaw please only make one change per PR, (don't bring the GCP thing in, as it's unrelated, and just makes it less likely to get merged) Once @shannonbradshaw removes that other commit, I believe it's fine to merge. EDIT: Just to clarify, as there is not really a governance body who can vote on this, unless there is significant objection within the committers, lets move forwards |
This reverts commit 0eacee5.
@thesuperzapper @RFMVasconcelos @Bobgy ok I reverted the last commit per @thesuperzapper's request. |
/approve |
Do you really need to add the AWS acronym @shannonbradshaw ? |
/ok-to-test Holding for the AWS acronym |
@thesuperzapper if we use the acronym it should be defined. That is a docs best practice. |
From my point of view, we should include all distribution in the official Kubeflow docs that vendors support. There are couple of advantages by doing this for Kubeflow 1.3:
I don't see any problems with merging this PR. /lgtm |
Thank you for your comment @andreyvelich! Given your support + @thesuperzapper and @Bobgy's ack, I think I can pull the trigger to add this distribution without upsetting anyone in the community. Apologies for the delay on this @cvenets @shannonbradshaw @castrojo @jbottum, having more people chime in was important for me to be making this call. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbottum, RFMVasconcelos, shannonbradshaw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Fixes #2639
cc: @RFMVasconcelos here's the PR for the Arrikto EKF description as discussed on #2611