Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Getting Started"/"Workstation Installation" #2605

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Apr 14, 2021

Closes #2565

As discussed in #2565, we are going to drop the "Workstation Installation" docs in favour of a refactored "Installing Kubeflow" page, see issue: #2590

@rui-vas
Copy link
Contributor

rui-vas commented Apr 14, 2021

Thank you for this PR @thesuperzapper !

/lgtm

Do you think we should wait for #2590? They are a bit orthogonal, given the well structured distributions list.

@thesuperzapper
Copy link
Member Author

@RFMVasconcelos I agree that both this and #2590 should be merged at the same time, if only so that there aren't dangling links in the "Installing Kubeflow" page.

@rui-vas
Copy link
Contributor

rui-vas commented Apr 14, 2021

Sounds like a good plan :)

@thesuperzapper
Copy link
Member Author

@RFMVasconcelos as we are about to merge #2611, I think we can go ahead an merge this.

Copy link
Contributor

@rui-vas rui-vas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesuperzapper as we now merged #2611, as agreed these workstation docs become redundant.

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RFMVasconcelos, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 3bcaf0a into kubeflow:master Apr 22, 2021
@thesuperzapper thesuperzapper deleted the remove_workstation branch November 22, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "Workstation Installation" under "Distributions"
3 participants