Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for EIP QoS #2550

Merged
merged 8 commits into from
Apr 10, 2023
Merged

Conversation

shane965
Copy link
Contributor

  1. Create a QoSPolicy CRD and manage its lifecycle.
  2. Add a new "spec.qosPolicy" field to iptablesEIP to relate to the QoSPolicy.
  3. Configure NATGW EIP QoS when "spec.qosPolicy" changes.
  4. Implement NATGW EIP QoS functionality using Linux TC.

What type of this PR

  • Features

Which issue(s) this PR fixes:

Fixes #2496

dist/images/cleanup.sh Outdated Show resolved Hide resolved
dist/images/vpcnatgateway/nat-gateway.sh Outdated Show resolved Hide resolved
dist/images/vpcnatgateway/nat-gateway.sh Outdated Show resolved Hide resolved
dist/images/vpcnatgateway/nat-gateway.sh Outdated Show resolved Hide resolved
dist/images/vpcnatgateway/nat-gateway.sh Outdated Show resolved Hide resolved
pkg/apis/kubeovn/v1/status.go Outdated Show resolved Hide resolved
pkg/apis/kubeovn/v1/types.go Outdated Show resolved Hide resolved
pkg/controller/qos_policy.go Outdated Show resolved Hide resolved
pkg/controller/vpc_nat_gw_eip.go Outdated Show resolved Hide resolved
pkg/controller/vpc_nat_gw_eip.go Show resolved Hide resolved
@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs or format errors in the diff.
  • It is difficult to assess performance issues without further context on the codebase and the changes made.
  • Ways to improve could include adding comments to explain complex logic, using more descriptive variable names, and following consistent coding style throughout the codebase.

@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative. It should briefly explain what changes were made and why.
  • There are no potential bugs or format errors in the diff.
  • It is difficult to assess performance issues without more context about the code being changed.
  • It would be helpful to include comments in the code explaining the purpose of each change and how it improves the code.
  • It would be beneficial to include unit tests to ensure that the changes do not introduce new bugs or regressions.

@shane965 shane965 marked this pull request as ready for review March 28, 2023 01:00
pkg/apis/kubeovn/v1/types.go Outdated Show resolved Hide resolved
pkg/controller/qos_policy.go Outdated Show resolved Hide resolved
1. Create a QoSPolicy CRD and manage its lifecycle.
2. Add a new "spec.qosPolicy" field to iptablesEIP to relate to
the QoSPolicy.
3. Configure NATGW EIP QoS when "spec.qosPolicy" changes.
4. Implement NATGW EIP QoS functionality using Linux TC.
@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why they were necessary.
  • There are no potential bugs identified in the diff, but it is always important to thoroughly test any changes before committing them to ensure that they do not introduce new bugs or issues.
  • The formatting of the code appears to be consistent and follows best practices, so no format errors have been identified.
  • There are no obvious performance issues with the code patch, but it is always a good idea to consider potential performance impacts when making changes to code.
  • It would be helpful to include comments in the code to explain what each section does and why it is necessary. This can make it easier for other developers to understand and maintain the code in the future.

@zbb88888 zbb88888 requested a review from hongzhen-ma March 28, 2023 05:35
@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs identified in the diff, but it would be helpful to have some comments explaining the changes made for future reference.
  • The formatting of the code could be improved for readability. For example, adding whitespace between operators and using consistent indentation.
  • There are no performance issues identified in the diff, but it would be helpful to run some tests to ensure that the changes do not negatively impact performance.
  • It would be helpful to include some unit tests to ensure that the changes made do not introduce new bugs or regressions.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why they were necessary.
  • There are no potential bugs or format errors in the patch diff.
  • It is difficult to assess performance issues without more context about the code being modified.
  • Ways to improve could include adding comments to explain the purpose of certain sections of code, using more descriptive variable names, and following consistent coding conventions throughout the file.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why they were necessary.
  • There are no potential bugs identified in the diff, but it would be helpful to have more context on the code being changed to ensure that there are no unintended consequences.
  • The formatting of the code could be improved for readability. Consistent indentation and spacing should be used throughout the file.
  • There are no performance issues identified in the diff, but it would be helpful to have more information on the expected performance impact of the changes.
  • Consider adding comments to the code to explain the purpose of each function or block of code. This will make it easier for other developers to understand and maintain the code in the future.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why they were necessary.
  • There are no potential bugs or format errors in the diff.
  • It is difficult to assess performance issues without more context about the code being modified.
  • It would be helpful to include comments in the code explaining the purpose of each change and how it improves the overall functionality.
  • Consider adding unit tests to ensure that the changes do not introduce new bugs or regressions.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why they were necessary.
  • There are no potential bugs identified in the diff, but a thorough testing of the code is recommended to ensure that there are no unintended consequences of the changes made.
  • The formatting of the code could be improved for better readability. Consistent indentation and spacing should be used throughout the code.
  • There are no performance issues identified in the diff, but it's always good practice to consider the impact of any changes on the overall performance of the system.
  • The code patch diff could benefit from comments explaining the purpose and functionality of each section of code. This will make it easier for other developers to understand and maintain the code in the future.

@shane965
Copy link
Contributor Author

shane965 commented Apr 6, 2023

@hongzhen-ma , could you review my code? Thank you!

dist/images/vpcnatgateway/nat-gateway.sh Show resolved Hide resolved
docs/eip-qos.md Show resolved Hide resolved
pkg/controller/vpc_nat_gw_eip.go Outdated Show resolved Hide resolved
pkg/controller/vpc_nat_gw_eip.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs or format errors in the patch diff.
  • It is difficult to assess performance issues without further context on the codebase and the changes made.
  • Ways to improve could include adding comments to explain complex logic, using more descriptive variable names, and following consistent coding conventions throughout the codebase.

@zbb88888 zbb88888 merged commit 53bf75d into kubeovn:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP Qos support
3 participants