-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for EIP QoS #2550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbb88888
reviewed
Mar 27, 2023
zbb88888
reviewed
Mar 27, 2023
zbb88888
requested changes
Mar 27, 2023
|
shane965
force-pushed
the
eip-qos-support
branch
from
March 28, 2023 00:52
84c0225
to
d269deb
Compare
|
zbb88888
reviewed
Mar 28, 2023
1. Create a QoSPolicy CRD and manage its lifecycle. 2. Add a new "spec.qosPolicy" field to iptablesEIP to relate to the QoSPolicy. 3. Configure NATGW EIP QoS when "spec.qosPolicy" changes. 4. Implement NATGW EIP QoS functionality using Linux TC.
shane965
force-pushed
the
eip-qos-support
branch
from
March 28, 2023 03:47
d269deb
to
c6be307
Compare
|
zbb88888
approved these changes
Mar 28, 2023
|
|
zbb88888
reviewed
Apr 3, 2023
|
zbb88888
approved these changes
Apr 3, 2023
|
zbb88888
approved these changes
Apr 4, 2023
|
@hongzhen-ma , could you review my code? Thank you! |
hongzhen-ma
reviewed
Apr 10, 2023
|
hongzhen-ma
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #2496