Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cloud-config for external CCM #169

Closed
1 task
xmudrii opened this issue Jan 11, 2019 · 13 comments
Closed
1 task

Support cloud-config for external CCM #169

xmudrii opened this issue Jan 11, 2019 · 13 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Not that urgent, but is important
Milestone

Comments

@xmudrii
Copy link
Member

xmudrii commented Jan 11, 2019

Follow-up of #161

When using external CCM, the cluster will not be configured to use cloud-config even if it is provided. Instead we should check if it is provided, and if yes, configure external CCM to use the provided cloud-config.

Acceptance criteria:

  • It is possible to use cloud-config with external CCM
@xmudrii xmudrii added kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important labels Jan 11, 2019
@xmudrii xmudrii added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Mar 1, 2019
@xmudrii xmudrii added this to the v0.3.0 milestone Mar 1, 2019
@kron4eg
Copy link
Member

kron4eg commented Mar 4, 2019

dependent and blocked by #227 as they share common idea/logic

@xmudrii
Copy link
Member Author

xmudrii commented Mar 5, 2019

/assign
/lifecycle active

@kubermatic-bot kubermatic-bot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 5, 2019
@xmudrii xmudrii removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 5, 2019
@xmudrii xmudrii modified the milestones: v0.3.0, Someday Mar 5, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Mar 5, 2019

Blocked as we're unsure how cloud-config will be handled for out-of-tree CCMs

@xmudrii
Copy link
Member Author

xmudrii commented Mar 10, 2019

/assign

Check with SIG Cloud Provider about this

@xmudrii
Copy link
Member Author

xmudrii commented Mar 12, 2019

/unassign

This issue is still relevant.

@xmudrii xmudrii modified the milestones: Someday, v0.4.0 Mar 12, 2019
@kron4eg
Copy link
Member

kron4eg commented Mar 13, 2019

Blocked as we're unsure how cloud-config will be handled for out-of-tree CCMs

As usually, we only need to specify --cloud-config. More info here:
https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/openstack-kubernetes-integration-options.md#external-openstack-provider

@kron4eg
Copy link
Member

kron4eg commented Mar 13, 2019

blocked by #255

/lifecycle blocked

@kron4eg kron4eg added the lifecycle/blocked Denotes an issue or PR is blocked. label Mar 13, 2019
@kron4eg kron4eg modified the milestones: v0.4.0, Someday Mar 13, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Mar 13, 2019

This issue is not blocked by #255 and can be fixed in this milestone. Nothing prevents us from deploying cloud-config if it is provided in the KubeOne manifest.

@xmudrii xmudrii removed the lifecycle/blocked Denotes an issue or PR is blocked. label Mar 13, 2019
@xmudrii xmudrii modified the milestones: Someday, v0.4.0 Mar 13, 2019
@kron4eg
Copy link
Member

kron4eg commented Mar 13, 2019

@xmudrii If you mean upload cloud-config to /etc/kubermatic/cloud-config then it's already done unconditionally.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 13, 2019

Yes, I was talking about that. Was not aware, I thought we don't. Let's see is there anything else we can do and if not we'll close the issue. In that case it's already scope of #255.

@kron4eg
Copy link
Member

kron4eg commented Mar 13, 2019

Since we don't deploy any CCM currently, we have no place to stick that cloud-config 🤷‍♂️, that's why I've closed it initially.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 13, 2019

/close

@kubermatic-bot
Copy link
Contributor

@xmudrii: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Not that urgent, but is important
Projects
None yet
Development

No branches or pull requests

3 participants