Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy external Cloud Controller Manager (CCM) if Provider.External is set #255

Closed
xmudrii opened this issue Mar 12, 2019 · 2 comments · Fixed by #364
Closed

Deploy external Cloud Controller Manager (CCM) if Provider.External is set #255

xmudrii opened this issue Mar 12, 2019 · 2 comments · Fixed by #364
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@xmudrii
Copy link
Member

xmudrii commented Mar 12, 2019

Currently if Provider.External is set to true it's user's responsibility to deploy the external CCM. We should consider deploying the external CCM ourselves because currently we're running into many edge cases:

  • if --cloud-provider=external is set on Kubelet all nodes (including control plane nodes) will stay uninitialized until CCM is not deployed,
  • this prevents components to be deployed, including system components such as CoreDNS,
  • without CoreDNS, DNS functionality will not be available in the cluster and we can't create worker nodes,
  • for cloud providers without in-tree CCMs, not all information about nodes is populated, for example IP addresses

When deploying CCM ourselves we deny user from choosing what CCM version they want to run, however we're gaining more control and we can ensure that such CCM version is working on KubeOne clusters.

At this point, this issue is blocked until machine-controller doesn't implement features needed for the external CCM to work as expected.

/kind feature
/lifecycle blocked

UPDATE:
Need to reference machine-controller credentials secret from CCM deployment.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 18, 2019

Blocked by machine-controller supporting external CCM

@xmudrii xmudrii added the lifecycle/blocked Denotes an issue or PR is blocked. label Mar 18, 2019
@kron4eg kron4eg removed the lifecycle/blocked Denotes an issue or PR is blocked. label Mar 21, 2019
@kron4eg
Copy link
Member

kron4eg commented Mar 21, 2019

--cloud-provider=external is merged in kubermatic/machine-controller#470

@kron4eg kron4eg assigned kron4eg and unassigned kron4eg Apr 5, 2019
@kron4eg kron4eg self-assigned this Apr 22, 2019
@kron4eg kron4eg added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants