Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy external CCMs #364

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Deploy external CCMs #364

merged 4 commits into from
Apr 24, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 22, 2019 •
edited
Loading

Fixes #255

There will be a follow up PR, once this and #362 merged that will introduce external: true flag to DO and hetzner

Deploy Hetzner CCM when provider.name: 'hetzner' and provider.external: true
Deploy DigitalOcean CCM when provider.name: 'digitalocean' and provider.external: true

@kron4eg kron4eg requested a review from xmudrii April 22, 2019 14:38
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 22, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Apr 22, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Apr 22, 2019

/retest

2 similar comments
@kron4eg
Copy link
Member Author

kron4eg commented Apr 22, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Apr 23, 2019

/retest

xmudrii
xmudrii requested changes Apr 23, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks okay, but I'll take an in-depth look once I'm back from the vacation.

pkg/templates/externalccm/ccm.go
case config.ProviderNameDigitalOcean:
return ensureDigitalOcean(ctx)
default:
ctx.Logger.Infof("External CCM for %q not yet supported, skipping", ctx.Cluster.Provider.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a message that the user should deploy it manually, e.g. External CCM for %q not yet supported, please deploy CCM manually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please deploy CCM manually is implied, since we can't install them 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer being explicit in the user-facing error messages.

Copy link
Member Author

@kron4eg kron4eg Apr 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to run pipeline again just for "notice", as then it easily can take days to stabilize because everything is flaky.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering you have to rebase the PR, you can fix this. 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too late, already rebased :P

pkg/templates/externalccm/ccm.go Show resolved Hide resolved
pkg/templates/externalccm/digitalocean.go Show resolved Hide resolved
@kron4eg
Deploy Hetzner CCM when cloud-provider=external
ee5fa9f 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Deploy DigitalOcean CCM when cloud-provider=external
cc27e1b 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Add forgotten boilerplate headers
38b1d76 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
fix DO image tag
5be2895 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@xmudrii
Copy link
Member

xmudrii commented Apr 24, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 24, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02e4f40a4ebc8907425a24347cb1d8f8908510f1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@xmudrii
Copy link
Member

xmudrii commented Apr 24, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 18bb75b into master Apr 24, 2019
@kubermatic-bot kubermatic-bot deleted the ccm branch April 24, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy external Cloud Controller Manager (CCM) if Provider.External is set
3 participants
@kron4eg @xmudrii @kubermatic-bot