Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch coreDNS deployment for external cloud provider #362

Merged
merged 1 commit into from
Apr 24, 2019
Merged

patch coreDNS deployment for external cloud provider #362

merged 1 commit into from
Apr 24, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 19, 2019

What this PR does / why we need it:
Updating coredns with uninitialized toleration in case when cloudprovider=external

NONE

@kron4eg kron4eg requested a review from xmudrii April 19, 2019 22:59
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Apr 20, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Apr 20, 2019

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2019
@kron4eg
patch coreDNS deployment for external cloud provider
5fc564e 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented Apr 20, 2019

/hold cancel
/assign @xmudrii

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Apr 20, 2019

/retest

@kron4eg kron4eg mentioned this pull request Apr 22, 2019
Merged
xmudrii
xmudrii approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d965b88b53e2fc5b6155c8feeb6799e3b57ad27d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@kubermatic-bot kubermatic-bot merged commit 2a86e7a into master Apr 24, 2019
@kubermatic-bot kubermatic-bot deleted the coredns branch April 24, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii