General Amazon Linux 2 support #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
Skipping CI for Draft Pull Request. |
kubermatic-bot
added
the
size/XXL
kubermatic-bot
added
the
needs-rebase
kubermatic-bot
removed
the
needs-rebase
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/assign @xmudrii |
xmudrii
reviewed
May 13, 2021
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
kron4eg
commented
May 13, 2021
| @@ -88,13 +88,6 @@ func EksdTerraformFlags(provider string) ([]string, error) { | |||
| flags := []string{ | |||
| "-var", "initial_machinedeployment_replicas=0", | |||
| "-var", "static_workers_count=3", | |||
| // Amazon Linux 2 is currently not supported by machine-controller. | |||
There was a problem hiding this comment.
It's supported as of 1.29.1 (kubermatic/machine-controller#964)
xmudrii
approved these changes
May 14, 2021
|
LGTM label has been added. Git tree hash: d2ce2577911f2484920fc5c8eb577ab303412a4c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xref #1196
Fixes #1198
Special notes for your reviewer:
Does this PR introduce a user-facing change?: