Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon Linux 2 on AWS #964

Merged
merged 15 commits into from
May 12, 2021
Merged

Amazon Linux 2 on AWS #964

merged 15 commits into from
May 12, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 6, 2021

What this PR does / why we need it:
Amazon Linux 2 on AWS

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Optional Release Note:

Support Amazon Linux 2 on AWS

@kron4eg
Add amzn2 userdata OS
fe05d46 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Use wildcard hack for yum/apt-get install
dc9f24e 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
amzn2 E2E
62335b7 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Default AWS filter for AmazonLinux2 AMI
a502f29 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2021
@kron4eg
Copy link
Member Author

kron4eg commented May 6, 2021

/test pull-machine-controller-e2e-aws-amzn2

@kron4eg
Add missing \ in ubuntu
1230451 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented May 6, 2021

/test pull-machine-controller-e2e-aws-amzn2

@kron4eg
remove dedicated pull-machine-controller-e2e-aws-amzn2
7f9f560 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix E2E OS selectors
2be667e 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Remove unused TestAWSAmzn2ProvisioningE2E
525e4db 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Add missing amzn2 plugin to the supported OS plugins list
15f57ba 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix missing default root path for amzn2
ae0ae98 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix systemctl containerd for amzn2
82c5f62 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented May 10, 2021

/retest

@kron4eg kron4eg requested a review from moadqassem May 10, 2021 15:39
@kron4eg
Copy link
Member Author

kron4eg commented May 10, 2021

/retest

@kron4eg kron4eg assigned kron4eg and moadqassem and unassigned kron4eg May 10, 2021
@kron4eg
Copy link
Member Author

kron4eg commented May 10, 2021

/retest

5 similar comments
@kron4eg
Copy link
Member Author

kron4eg commented May 10, 2021

/retest

@kron4eg
Copy link
Member Author

kron4eg commented May 10, 2021

/retest

@kron4eg
Copy link
Member Author

kron4eg commented May 11, 2021

/retest

@kron4eg
Copy link
Member Author

kron4eg commented May 11, 2021

/retest

@kron4eg
Copy link
Member Author

kron4eg commented May 11, 2021

/retest

moadqassem
moadqassem reviewed May 11, 2021
View reviewed changes
cmd/userdata/amzn2/main.go Outdated
@@ -0,0 +1,46 @@
/*
Copyright 2019 The Machine Controller Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2019 The Machine Controller Authors.
Copyright 2021 The Machine Controller Authors.

cmd/userdata/amzn2/main.go Outdated Show resolved Hide resolved
cmd/userdata/amzn2/main.go Show resolved Hide resolved
pkg/userdata/amzn2/amzn.go Outdated Show resolved Hide resolved
pkg/userdata/amzn2/provider.go Outdated Show resolved Hide resolved
@kron4eg
fix typo
f6fc338 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
add mention of amzn2 to supportted OS doc
58d9975 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@xrstf
Copy link
Contributor

xrstf commented May 11, 2021

/test pull-machine-controller-e2e-aws-amzn2

@kubermatic-bot
Copy link
Contributor

@xrstf: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubermatic-machine-controller-validate-prow-yaml
  • /test pull-machine-controller-e2e-hetzner-new-worker
  • /test pull-machine-controller-build
  • /test pull-machine-controller-dependencies
  • /test pull-machine-controller-lint
  • /test pull-machine-controller-yamllint
  • /test pre-machine-controller-verify-shfmt
  • /test pull-machine-controller-verify-boilerplate
  • /test pull-machine-controller-license-validation
  • /test pull-machine-controller-test
  • /test pull-machine-controller-e2e-invalid-objects-get-rejected
  • /test pull-machine-controller-e2e-kubevirt
  • /test pull-machine-controller-e2e-kubevirt-dns-config
  • /test pull-machine-controller-e2e-alibaba
  • /test pull-machine-controller-e2e-custom-ca
  • /test pull-machine-controller-e2e-openstack
  • /test pull-machine-controller-e2e-aws
  • /test pull-machine-controller-e2e-aws-arm
  • /test pull-machine-controller-e2e-digitalocean
  • /test pull-machine-controller-e2e-azure
  • /test pull-machine-controller-e2e-azure-custom-image-reference
  • /test pull-machine-controller-e2e-azure-redhat-satellite
  • /test pull-machine-controller-e2e-gce
  • /test pull-machine-controller-e2e-hetzner
  • /test pull-machine-controller-e2e-linode
  • /test pull-machine-controller-e2e-packet
  • /test pull-machine-controller-e2e-cherryservers
  • /test pull-machine-controller-e2e-vsphere
  • /test pull-machine-controller-e2e-anexia
  • /test pull-machine-controller-e2e-ubuntu-upgrade
  • /test pull-machine-controller-e2e-deployment-upgrade
  • /test pull-machine-controller-e2e-aws-ebs-encryption-enabled
  • /test pull-machine-controller-e2e-aws-flatcar-containerd
  • /test pull-machine-controller-e2e-aws-sles
  • /test pull-machine-controller-e2e-aws-flatcar-coreos-cloud-init
  • /test pull-machine-controller-e2e-aws-centos8
  • /test pull-machine-controller-e2e-vsphere-datastore-cluster
  • /test pull-machine-controller-e2e-vsphere-resource-pool
  • /test pull-machine-controller-e2e-scaleway

Use /test all to run the following jobs:

  • pull-kubermatic-machine-controller-validate-prow-yaml
  • pull-machine-controller-build
  • pull-machine-controller-dependencies
  • pull-machine-controller-lint
  • pull-machine-controller-yamllint
  • pull-machine-controller-verify-boilerplate
  • pull-machine-controller-test
  • pull-machine-controller-e2e-invalid-objects-get-rejected
  • pull-machine-controller-e2e-kubevirt
  • pull-machine-controller-e2e-kubevirt-dns-config
  • pull-machine-controller-e2e-custom-ca
  • pull-machine-controller-e2e-openstack
  • pull-machine-controller-e2e-aws
  • pull-machine-controller-e2e-aws-arm
  • pull-machine-controller-e2e-digitalocean
  • pull-machine-controller-e2e-azure
  • pull-machine-controller-e2e-azure-custom-image-reference
  • pull-machine-controller-e2e-gce
  • pull-machine-controller-e2e-hetzner
  • pull-machine-controller-e2e-vsphere
  • pull-machine-controller-e2e-ubuntu-upgrade
  • pull-machine-controller-e2e-deployment-upgrade
  • pull-machine-controller-e2e-aws-ebs-encryption-enabled
  • pull-machine-controller-e2e-aws-flatcar-containerd
  • pull-machine-controller-e2e-vsphere-resource-pool

In response to this:

/test pull-machine-controller-e2e-aws-amzn2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented May 11, 2021

/test pull-machine-controller-e2e-aws-amzn2

this one has been removed right after adding since it's already included in pull-machine-controller-e2e-aws

@xrstf
Copy link
Contributor

xrstf commented May 11, 2021

/override pull-machine-controller-e2e-azure

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-azure

In response to this:

/override pull-machine-controller-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented May 11, 2021

@moadqassem OK, comments are addressed, PTAL again.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e185816353e5e76f6588e2240f8b5c8ccae8d05c

moadqassem
moadqassem reviewed May 11, 2021
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor

xrstf commented May 12, 2021

/override pull-machine-controller-e2e-azure

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-azure

In response to this:

/override pull-machine-controller-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit e368d5b into kubermatic:master May 12, 2021
@kron4eg kron4eg deleted the amzn2 branch May 12, 2021 07:46
@kubermatic-bot
Copy link
Contributor

@kron4eg: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-machine-controller-e2e-aws-amzn2 1230451 link /test pull-machine-controller-e2e-aws-amzn2
pull-machine-controller-e2e-azure 58d9975 link /test pull-machine-controller-e2e-azure

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg kron4eg mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem moadqassem left review comments

Assignees

@moadqassem moadqassem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kron4eg @xrstf @kubermatic-bot @kubermatic-triage-bot @moadqassem